Re: [PATCH] emacs: call "notmuch tag" only once when archiving a thread

diff --git a/eb/4c05d7135d12139e5193dd3793e24c00f55bcb b/eb/4c05d7135d12139e5193dd3793e24c00f55bcb
new file mode 100644 (file)
index 0000000..ed4cb89
--- /dev/null
+++ b/eb/4c05d7135d12139e5193dd3793e24c00f55bcb
@@ -0,0 +1,78 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 81E1A429E32\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Jan 2012 12:58:36 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 566X-1azUxHd for <notmuch@notmuchmail.org>;\r
+       Thu,  5 Jan 2012 12:58:36 -0800 (PST)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ C897B429E31   for <notmuch@notmuchmail.org>; Thu,  5 Jan 2012 12:58:35 -0800\r
+ (PST)\r
+Received: by eekd41 with SMTP id d41so778240eek.26\r
+       for <notmuch@notmuchmail.org>; Thu, 05 Jan 2012 12:58:34 -0800 (PST)\r
+Received: by 10.14.11.164 with SMTP id 36mr1244806eex.107.1325797114479;\r
+       Thu, 05 Jan 2012 12:58:34 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi.\r
+       [80.220.92.23])\r
+       by mx.google.com with ESMTPS id t1sm238417448eeb.3.2012.01.05.12.58.31\r
+       (version=SSLv3 cipher=OTHER); Thu, 05 Jan 2012 12:58:32 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: call "notmuch tag" only once when archiving a\r
+       thread\r
+In-Reply-To: <87vcop3mx1.fsf@servo.finestructure.net>\r
+References: <1325615346-8302-1-git-send-email-jani@nikula.org>\r
+       <m2hb09kj0m.fsf@gmail.com> <87fwftao1b.fsf@nikula.org>\r
+       <87vcop3mx1.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.10.2+182~g93862a2 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+Date: Thu, 05 Jan 2012 22:58:30 +0200\r
+Message-ID: <87d3axamtl.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 05 Jan 2012 20:58:36 -0000\r
+\r
+On Thu, 05 Jan 2012 12:38:18 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> > In the search view it does exactly this.\r
+> \r
+> I worry about race conditions in this case, though.  I frequently\r
+> archive threads after I've read everything, but I still want to know if\r
+> new message to that thread come in.  If I attempt to archive a thread in\r
+> notmuch-search, but a new message has entered the thread without me\r
+> knowing it, I'll archive the new message before I had a chance to look\r
+> at it.\r
+\r
+Just to be clear: The patch in question does not alter this\r
+behaviour. The race you describe is there already.\r
+\r
+And at a glance, it does not look like something that would be trivial\r
+to fix. The buffer does not have the information to do that.\r
+\r
+\r
+BR,\r
+Jani.\r