Re: [PATCH v4 06/12] test: add tests for insert

diff --git a/ff/cc87493e007ddef94e1306402b1ccba7938868 b/ff/cc87493e007ddef94e1306402b1ccba7938868
new file mode 100644 (file)
index 0000000..548b675
--- /dev/null
+++ b/ff/cc87493e007ddef94e1306402b1ccba7938868
@@ -0,0 +1,65 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DAEC8431FC2\r
+       for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 18:48:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xL8nUo9RvUfg for <notmuch@notmuchmail.org>;\r
+       Fri, 29 Mar 2013 18:48:52 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 915ED431FBF\r
+       for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 18:48:52 -0700 (PDT)\r
+Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1ULkuZ-000616-AF; Fri, 29 Mar 2013 22:48:51 -0300\r
+Received: (nullmailer pid 15258 invoked by uid 1000);\r
+       Fri, 29 Mar 2013 23:59:56 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 06/12] test: add tests for insert\r
+In-Reply-To: <1359029288-12132-7-git-send-email-novalazy@gmail.com>\r
+References: <1359029288-12132-1-git-send-email-novalazy@gmail.com>\r
+       <1359029288-12132-7-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 29 Mar 2013 19:59:56 -0400\r
+Message-ID: <87d2uhiwoz.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 30 Mar 2013 01:48:53 -0000\r
+\r
+\r
+It took longer than I thought (of course) but I finally finished looking\r
+at the first 6 patches. \r
+\r
+I already mentioned a minor man page issue in a seperate message.\r
+\r
+I took a second pass through 03/12, and I think I would prefer thethe\r
+control flow of insert_message be closer to the standard style in\r
+notmuch of using a return value variable and a single cleanup block at\r
+the end.  Reasonable people can disagree about issues of style, but in\r
+the end consistency of the code base is also important.\r
+\r
+d\r