Re: [Patch v7 05/14] quote_and_decode_query: new function to quote hex-decoded queries

diff --git a/31/9de193ae067149dae8407ce59f03fff0572ebc b/31/9de193ae067149dae8407ce59f03fff0572ebc
new file mode 100644 (file)
index 0000000..6aa06bb
--- /dev/null
+++ b/31/9de193ae067149dae8407ce59f03fff0572ebc
@@ -0,0 +1,68 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 49715431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 19:39:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GAVlnTjRMJTt for <notmuch@notmuchmail.org>;\r
+       Sat, 15 Dec 2012 19:39:50 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9CBB1431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 19:39:50 -0800 (PST)\r
+Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.167.90.129] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tk54u-0007CT-HF; Sat, 15 Dec 2012 23:39:48 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tk54o-0007SI-Vf; Sat, 15 Dec 2012 23:39:43 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v7 05/14] quote_and_decode_query: new function to quote\r
+       hex-decoded queries\r
+In-Reply-To: <87mwxeq4uz.fsf@nikula.org>\r
+References: <1355492062-7546-1-git-send-email-david@tethera.net>\r
+       <1355492062-7546-6-git-send-email-david@tethera.net>\r
+       <87mwxeq4uz.fsf@nikula.org>\r
+User-Agent: Notmuch/0.14+163~g11a220a (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 15 Dec 2012 23:39:42 -0400\r
+Message-ID: <87zk1e4qdd.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 16 Dec 2012 03:39:51 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> strtok_len() will eat all the leading delimiters at each call, and will\r
+> not return a zero-length token if you have multiple consecutive\r
+> delimiters. Which means you may end up losing stuff here.\r
+\r
+Right, I think for ':' it does matter, but it should be fixable with a\r
+a little loop to copy ':'s to the query string after the (possibly quoted)\r
+token.\r