Re: [PATCH 00/11] Improve charset and cid: handling

diff --git a/02/139636d9c7e78e44eb99eeb7ff5518331a19db b/02/139636d9c7e78e44eb99eeb7ff5518331a19db
new file mode 100644 (file)
index 0000000..0921a71
--- /dev/null
+++ b/02/139636d9c7e78e44eb99eeb7ff5518331a19db
@@ -0,0 +1,120 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E6F2A431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 26 Apr 2014 03:51:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id I1RDV94LB3DQ for <notmuch@notmuchmail.org>;\r
+       Sat, 26 Apr 2014 03:51:07 -0700 (PDT)\r
+Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 760FE431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 26 Apr 2014 03:51:07 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail1.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1We0CC-0006JS-OO; Sat, 26 Apr 2014 11:51:03 +0100\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1We0CC-0006Lg-H6; Sat, 26 Apr 2014 11:51:00 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Improve charset and cid: handling\r
+In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 26 Apr 2014 11:50:56 +0100\r
+Message-ID: <87tx9gl5yn.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: a0adc557c4a0351168ac667c3bd0f1dd (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.1 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 26 Apr 2014 10:51:15 -0000\r
+\r
+\r
+Aside from the minor comments I mentioned in previous emails and one\r
+more comment below this looks good. \r
+\r
+The extra comment is that on emacs23 I get the following when compiling:\r
+\r
+In end of data:\r
+notmuch-show.el:2188:1:Warning: the following functions are not known to be\r
+    defined: libxml-parse-html-region, shr-insert-document\r
+\r
+Finally, I have not really tested it as I mainly use emacs23\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+On Mon, 21 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> I set out to quickly add support for cid: links in the shr renderer\r
+> and wound up making our charset handling more robust and rewriting our\r
+> content-ID handling.  The test introduced in patch 2 passes in all but\r
+> one really obscure case, but only because of many unwritten and\r
+> potentially fragile assumptions that Emacs and the CLI make about each\r
+> other.\r
+>\r
+> The first three patches could reasonably go in to 0.18.  The rest of\r
+> this series is certainly post-0.18, but I didn't want to lose track of\r
+> it.\r
+>\r
+> This series comes in three stages.  Each depends on the earlier ones,\r
+> but each prefix makes sense on its own and could be pushed without the\r
+> later stages.\r
+>\r
+> Patch 1 is a simple clean up patch.\r
+>\r
+> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly\r
+> by splitting the broken `notmuch-get-bodypart-content' API into\r
+> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a\r
+> caller can explicitly convey their requirements.\r
+>\r
+> The remaining patches improve our content-ID handling and add support\r
+> for cid: links for shr.\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r