Re: [PATCH 4/4] test: give unique timestamps to messages
authorAustin Clements <amdragon@MIT.EDU>
Mon, 9 Dec 2013 00:28:13 +0000 (19:28 +1900)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:58:40 +0000 (09:58 -0800)
8c/7b1042c51083dac6e45bbe80834a116261c0cf [new file with mode: 0644]

diff --git a/8c/7b1042c51083dac6e45bbe80834a116261c0cf b/8c/7b1042c51083dac6e45bbe80834a116261c0cf
new file mode 100644 (file)
index 0000000..03bc756
--- /dev/null
@@ -0,0 +1,130 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A91D2431FD0\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:28:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id SrB2CpK6S1VC for <notmuch@notmuchmail.org>;\r
+       Sun,  8 Dec 2013 16:28:17 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
+       [18.7.68.37])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AFF8B431FCB\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 16:28:17 -0800 (PST)\r
+X-AuditID: 12074425-b7fd96d000000c39-78-52a50e9f4dfd\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id F4.45.03129.F9E05A25; Sun,  8 Dec 2013 19:28:15 -0500 (EST)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id rB90SFgk009609; \r
+       Sun, 8 Dec 2013 19:28:15 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rB90SDhv006592\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Sun, 8 Dec 2013 19:28:14 -0500\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Vpohp-0006OQ-Kn; Sun, 08 Dec 2013 19:28:13 -0500\r
+Date: Sun, 8 Dec 2013 19:28:13 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 4/4] test: give unique timestamps to messages\r
+Message-ID: <20131209002753.GI8854@mit.edu>\r
+References: <1386517946-22054-1-git-send-email-david@tethera.net>\r
+       <1386517946-22054-5-git-send-email-david@tethera.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1386517946-22054-5-git-send-email-david@tethera.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0Z3PtzTI4OIPc4sbrd2MFtdvzmR2\r
+       YPJ4tuoWs8eWQ++ZA5iiuGxSUnMyy1KL9O0SuDI+LPnHXPBHtKL/VT97A2OHUBcjJ4eEgInE\r
+       /TPTmSFsMYkL99azdTFycQgJzGaSaL1xGCwhJLCBUeJJUzRE4hSTRNu+gywQzhJGifen7rKC\r
+       VLEIqEjc/TIVrINNQENi2/7ljCC2iICqxNVtk9lAbGYBaYlvv5uZQGxhAUeJZwvOg9XzCmhL\r
+       TLt7nB1iW6XE/X1nWSDighInZz5hgejVkrjx7yVQLwfYnOX/OEDCnAJOEgd3zwFbJQp0wpST\r
+       29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3Qt9HIzS/RSU0o3MYLD\r
+       2kV1B+OEQ0qHGAU4GJV4eFewLg0SYk0sK67MPcQoycGkJMo7mRsoxJeUn1KZkVicEV9UmpNa\r
+       fIhRgoNZSYRX6cSSICHelMTKqtSifJiUNAeLkjjvLQ77ICGB9MSS1OzU1ILUIpisDAeHkgTv\r
+       bl6goYJFqempFWmZOSUIaSYOTpDhPEDDl4HU8BYXJOYWZ6ZD5E8xKkqJ864BSQiAJDJK8+B6\r
+       YWnnFaM40CvCvMtBqniAKQuu+xXQYCagwZOuLgIZXJKIkJJqYFQ7Nldkj1DOrJ3hU5tnsDo9\r
+       fLOR3d1osucL3cm/meOeqK13esLU6iXmpcmm3uL48UzO6Wezbpks/lEkdW9iaCCrUevqrv+T\r
+       Cv2CW39OTdKfWXz67qR/avuvNmpyCIf9XMmgt1Ao5danaeuCopSu7FsmxPb93XxtY8UZbQp2\r
+       GQ5zFvXy8DNqBCmxFGckGmoxFxUnAgCs+ZHtFgMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Dec 2013 00:28:23 -0000\r
+\r
+Quoth David Bremner on Dec 08 at 11:52 pm:\r
+> The choice of decreasing timestamps is a hack which reduces the number\r
+> of existing tests which fail.  This can be changed to increasing\r
+> if/when somebody wants update another 47 tests.\r
+> ---\r
+>  test/excludes    | 4 ++--\r
+>  test/test-lib.sh | 2 +-\r
+>  2 files changed, 3 insertions(+), 3 deletions(-)\r
+> \r
+> diff --git a/test/excludes b/test/excludes\r
+> index f1ae9ea..8bbbc2d 100755\r
+> --- a/test/excludes\r
+> +++ b/test/excludes\r
+> @@ -67,7 +67,7 @@ thread:XXX   2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inb\r
+>  test_begin_subtest "Search, don't exclude \"deleted\" messages when --exclude=flag specified"\r
+>  output=$(notmuch search --exclude=flag subject:deleted | notmuch_search_sanitize)\r
+>  test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)\r
+> -thread:XXX   2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)"\r
+> +thread:XXX   2001-01-05 [1/2] Notmuch Test Suite; Deleted (deleted inbox unread)"\r
+>  \r
+>  test_begin_subtest "Search, don't exclude \"deleted\" messages from search if not configured"\r
+>  notmuch config set search.exclude_tags\r
+> @@ -152,7 +152,7 @@ ${matching_message_ids[5]}"\r
+>  test_begin_subtest "Search, exclude=flag (thread summary)"\r
+>  output=$(notmuch search --exclude=flag tag:test | notmuch_search_sanitize)\r
+>  test_expect_equal "$output" "thread:XXX   2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: single match: reply 2 (deleted inbox test unread)\r
+> -thread:XXX   2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 4 (deleted inbox test unread)\r
+> +thread:XXX   2001-01-05 [0/6] Notmuch Test Suite; All messages excluded: double match: reply 2 (deleted inbox test unread)\r
+>  thread:XXX   2001-01-05 [0/6] Notmuch Test Suite; Some messages excluded: single excluded match: reply 3 (deleted inbox test unread)\r
+>  thread:XXX   2001-01-05 [1/6] Notmuch Test Suite; Some messages excluded: single non-excluded match: reply 4 (deleted inbox test unread)\r
+>  thread:XXX   2001-01-05 [1/6] Notmuch Test Suite; No messages excluded: single match: reply 3 (inbox test unread)"\r
+> diff --git a/test/test-lib.sh b/test/test-lib.sh\r
+> index d238c66..792e477 100644\r
+> --- a/test/test-lib.sh\r
+> +++ b/test/test-lib.sh\r
+> @@ -356,7 +356,7 @@ generate_message ()\r
+>      fi\r
+>  \r
+>      if [ -z "${template[date]}" ]; then\r
+> -    template[date]="Fri, 05 Jan 2001 15:43:57 +0000"\r
+> +    template[date]=$(date -Ru -d@$((978709437 - gen_msg_cnt)))\r
+\r
+It would be worth adding a comment here to explain that the decreasing\r
+timestamp is a historical artifact, to save people the trouble of\r
+digging back in the log to figure out why it goes down.\r
+\r
+>      fi\r
+>  \r
+>      additional_headers=""\r