Re: [PATCH] cli: Flush stdout before fork()ing to run hooks

diff --git a/93/f379de6fa04db46a4e34649e777eacbf046a81 b/93/f379de6fa04db46a4e34649e777eacbf046a81
new file mode 100644 (file)
index 0000000..b398df8
--- /dev/null
+++ b/93/f379de6fa04db46a4e34649e777eacbf046a81
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8CB74431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Mar 2014 17:33:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jF+3Ma952+Z7 for <notmuch@notmuchmail.org>;\r
+       Tue, 25 Mar 2014 17:33:42 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id CFC4C431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Mar 2014 17:33:42 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WSbml-0000ab-TV; Tue, 25 Mar 2014 21:33:39 -0300\r
+Received: (nullmailer pid 32638 invoked by uid 1000); Wed, 26 Mar 2014\r
+       00:33:36 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli: Flush stdout before fork()ing to run hooks\r
+In-Reply-To: <1395609746-26801-1-git-send-email-amdragon@mit.edu>\r
+References: <1395609746-26801-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 25 Mar 2014 21:33:36 -0300\r
+Message-ID: <87txalhk7z.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 26 Mar 2014 00:33:47 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> Without this flush, if stdout is block buffered (which will happen if\r
+> it's a pipe or a file, for example) and the hook also writes to\r
+> stdout, then notmuch new's output will appear *after* the hook output.\r
+>\r
+> This situation may be a little esoteric, but it's good practice to\r
+> flush before you fork anyway.\r
+\r
+pushed.\r
+\r
+d\r