Re: [PATCH] build: check .git directory existence in srcdir (for out-of-tree builds)

diff --git a/1b/0a831f686c50569a12d6d04218470d89931bf7 b/1b/0a831f686c50569a12d6d04218470d89931bf7
new file mode 100644 (file)
index 0000000..497e2b7
--- /dev/null
+++ b/1b/0a831f686c50569a12d6d04218470d89931bf7
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 027F6431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:13:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 49HHLKm-lU0N for <notmuch@notmuchmail.org>;\r
+       Sat,  5 Jul 2014 05:12:46 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A90AE431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:12:46 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1X3Oon-0005in-LI; Sat, 05 Jul 2014 12:11:49 +0000\r
+Received: (nullmailer pid 31561 invoked by uid 1000); Sat, 05 Jul 2014\r
+       12:11:29 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] build: check .git directory existence in srcdir (for\r
+       out-of-tree builds)\r
+In-Reply-To: <1399404928-15471-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1399404928-15471-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 05 Jul 2014 09:11:29 -0300\r
+Message-ID: <874mywroni.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Jul 2014 12:13:00 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> So that $(VERSION) and version.stamp uses the git-describe -based\r
+> version data instead of the content of `version' file.\r
+>\r
+> For consistency also the git commands in Makefile[.local] target\r
+> `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ...\r
+> commands (inside ifeq($(IS_GIT),yes)). Attempting to make this\r
+> target outside of the tree will fail in any case.\r
+\r
+This seems to work OK; I wondered if an alternate method of setting (and\r
+exporting) GIT_DIR from the top level makefile would work as well, and\r
+be less intrusive?\r
+\r
+d\r