Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

diff --git a/72/fa3a324b0eaf73119624feca5826468a9672e0 b/72/fa3a324b0eaf73119624feca5826468a9672e0
new file mode 100644 (file)
index 0000000..b243f4d
--- /dev/null
+++ b/72/fa3a324b0eaf73119624feca5826468a9672e0
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 835FE431FC0\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:23:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FdjrSSuEfU2s for <notmuch@notmuchmail.org>;\r
+       Sat,  2 Nov 2013 05:23:41 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D1151431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 05:23:41 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VcaEm-0005mW-Ro; Sat, 02 Nov 2013 09:23:32 -0300\r
+Received: (nullmailer pid 17055 invoked by uid 1000); Sat, 02 Nov 2013\r
+       12:23:29 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted\r
+       database\r
+In-Reply-To: <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>\r
+References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>\r
+       <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>\r
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 02 Nov 2013 09:23:29 -0300\r
+Message-ID: <87fvrfrnzy.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 02 Nov 2013 12:23:46 -0000\r
+\r
+Ben Gamari <bgamari.foss@gmail.com> writes:\r
+\r
+> We never checked to ensure that the rmtree() of the old database\r
+> succeeded.\r
+>\r
+\r
+Is there some reason these patches (and the existing compact code in the\r
+lib) is using fprintf and not the status callback function? Most places\r
+we don't (yet) have logging callbacks, but here we do.\r
+\r
+d\r
+ \r