Re: [Patch v2 4/4] cli: add standard option processing to config and setup

diff --git a/6a/84554ae6c5c1a7b498a802596de44391c996e0 b/6a/84554ae6c5c1a7b498a802596de44391c996e0
new file mode 100644 (file)
index 0000000..b22e68e
--- /dev/null
+++ b/6a/84554ae6c5c1a7b498a802596de44391c996e0
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A0F626DE1989\r
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 03:22:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.443\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.443 tagged_above=-999 required=5 tests=[AWL=0.443]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5yTA_CVGVWVX for <notmuch@notmuchmail.org>;\r
+ Tue,  7 Apr 2015 03:22:25 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 5DA6E6DE1950\r
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 03:22:25 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.80) (envelope-from <david@tethera.net>)\r
+ id 1YfQcq-0000QS-QS; Tue, 07 Apr 2015 10:20:56 +0000\r
+Received: (nullmailer pid 25482 invoked by uid 1000); Tue, 07 Apr 2015\r
+ 10:20:38 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 4/4] cli: add standard option processing to config and\r
+ setup\r
+In-Reply-To: <87vbh8qu2s.fsf@qmul.ac.uk>\r
+References: <87d23ixnr7.fsf@maritornes.cs.unb.ca>\r
+ <1428322958-2887-1-git-send-email-david@tethera.net>\r
+ <1428322958-2887-5-git-send-email-david@tethera.net>\r
+ <87vbh8qu2s.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 07 Apr 2015 19:20:38 +0900\r
+Message-ID: <87vbh8gryh.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Apr 2015 10:22:27 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+>\r
+> Why "setup" here rather than argv[0] or similar? It seems inconsistent\r
+> with the other cases.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+You're right this deserves a comment. notmuch_setup_command is actually\r
+called with argv=NULL (hence the unused (char * argv). The argument\r
+types are constrained by the fact we use a table of function pointers to\r
+dispatch.\r
+\r
+d\r