--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1E712431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 7 Jul 2013 03:21:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id tKmgjLZmK-Fz for <notmuch@notmuchmail.org>;\r
+ Sun, 7 Jul 2013 03:21:49 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 03544431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 7 Jul 2013 03:21:48 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uvm69-0008Th-43; Sun, 07 Jul 2013 11:21:43 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uvm68-0000k1-PQ; Sun, 07 Jul 2013 11:21:41 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: hello: make --batch error gracefully\r
+In-Reply-To: <m2mwq0t5v5.fsf@guru.guru-group.fi>\r
+References: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com>\r
+ <m2mwq0t5v5.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 07 Jul 2013 11:21:39 +0100\r
+Message-ID: <87wqp2d618.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 06ab073cf17d9903f4bc03239633d510 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 07 Jul 2013 10:21:57 -0000\r
+\r
+\r
+Hi\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Fri, Jul 05 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>\r
+>> Recently notmuch-hello was converted to use batch count. However, it\r
+>> seems that several people run different versions of notmuch-emacs and\r
+>> notmuch-cli so this batch makes emacs fail with an error message if\r
+>> --batch is not available in the CLI.\r
+>> ---\r
+>> There have been two cases on irc of people getting backtraces when\r
+>> hitting this problem so it might be worth adding an informative error\r
+>> message.\r
+>\r
+> This change takes care of the mismatching version problem now -- for\r
+> a short while in most cases but in the future we might face with new\r
+> incompabilities that would -- again -- need new solution. Some day\r
+> we might have a pile of these who everyone is shy to remove from the\r
+> code base ;/\r
+\r
+I think we want the unless clause anyway: we do not want to try parsing\r
+something and getting stacktrace errors whatever happens. The error\r
+message will need updating so I should probably add a FIXME to the\r
+code. Perhaps the patch roughly as is could be applied to 0.16 and the\r
+fixed error message together with your ideas from below to master?\r
+\r
+> Although I am not against applying this patch (if there are supporters\r
+> of this) I'd like to concentrate fixing this for example the following\r
+> way:\r
+\r
+This looks good. Some thoughts below.\r
+\r
+> We'll add a global option to notmuch, e.g.\r
+>\r
+> --compatibility-version=x.y\r
+>\r
+> Whenever the caller chooses to use this option, notmuch checks whether\r
+> it can comply with the option -- it it can, execution continues, otherwise \r
+> aborts.\r
+\r
+I think the return value could indicate what the problem was (ie too new\r
+or too old): so frontends could decide to work around it (perhaps 22 and\r
+23 to come after the format-version return values). This would mean that\r
+callers would have an easier way of telling if --compatability-version\r
+is supported at all to ease the transition.\r
+\r
+I wondered whether it overlapped with Austin's format-version stuff but\r
+I think it is sufficiently different but some clear documentation as to\r
+which means what could be helpful.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> The compatibility is determined so that the major 'x' needs to be same\r
+> and caller may have lower 'y' that notmuch is capable of handling.\r
+>\r
+> For example. if notmuch compatibility version was 2.5\r
+>\r
+> --compatibility-version=1.9 -- abort\r
+> --compatibility-version=2.3 -- continue\r
+> --compatibility-version=2.5 -- continue\r
+> --compatibility-version=2.8 -- abort\r
+> --compatibility-version=3.1 -- abort\r
+>\r
+>\r
+> I can work on this (or on something similar) if this is generally thought\r
+> as a good idea...\r
+>\r
+>>\r
+>> Best wishes\r
+>>\r
+>> Mark\r
+>\r
+> Tomi\r
+>\r
+>\r
+>>\r
+>> emacs/notmuch-hello.el | 9 +++++++--\r
+>> 1 files changed, 7 insertions(+), 2 deletions(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+>> index 147c08c..fa46b7a 100644\r
+>> --- a/emacs/notmuch-hello.el\r
+>> +++ b/emacs/notmuch-hello.el\r
+>> @@ -402,8 +402,13 @@ options will be handled as specified for\r
+>> (plist-get options :filter)))\r
+>> "\n")))\r
+>> \r
+>> - (call-process-region (point-min) (point-max) notmuch-command\r
+>> - t t nil "count" "--batch")\r
+>> + (unless (= (call-process-region (point-min) (point-max) notmuch-command\r
+>> + t t nil "count" "--batch") 0)\r
+>> + (notmuch-logged-error "notmuch CLI version mismatch error (count --batch)\r
+>> +The most likely cause of this error is that the CLI is too old\r
+>> +to support count --batch and needs to be upgraded to the same\r
+>> +version as notmuch-emacs"))\r
+>> +\r
+>> (goto-char (point-min))\r
+>> \r
+>> (notmuch-remove-if-not\r
+>> -- \r
+>> 1.7.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff