Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message)

diff --git a/1b/2eefd335626631d23ec69d44bcabc04b37168b b/1b/2eefd335626631d23ec69d44bcabc04b37168b
new file mode 100644 (file)
index 0000000..3159ca6
--- /dev/null
+++ b/1b/2eefd335626631d23ec69d44bcabc04b37168b
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 334A06DE4DD0\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 17:08:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.007\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id tREUeJ1SvpgL for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Aug 2016 17:08:33 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 95DB46DE4DCF\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 17:08:32 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bYiyr-0004sl-7T; Sat, 13 Aug 2016 20:08:45 -0400\r
+Received: (nullmailer pid 30418 invoked by uid 1000);\r
+ Sun, 14 Aug 2016 00:08:22 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of\r
+ n_d_add_message)\r
+In-Reply-To: <1467970047-8013-11-git-send-email-dkg@fifthhorseman.net>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-11-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 14 Aug 2016 09:08:22 +0900\r
+Message-ID: <8760r45i15.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Aug 2016 00:08:42 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> diff --git a/lib/notmuch.h b/lib/notmuch.h\r
+> index b92d969..66b3503 100644\r
+> --- a/lib/notmuch.h\r
+> +++ b/lib/notmuch.h\r
+> @@ -605,6 +605,20 @@ notmuch_status_t\r
+>  notmuch_database_add_message (notmuch_database_t *database,\r
+>                            const char *filename,\r
+>                            notmuch_message_t **message);\r
+> +/**\r
+> + * Add a new message to the given notmuch database or associate an\r
+> + * additional filename with an existing message using specified\r
+> + * options.\r
+> + *\r
+> + * This does the same thing as notmuch_database_add_message except\r
+> + * that it passes a pre-configured set of indexing options to indicate\r
+> + * how the specific message should be indexed.\r
+> + */\r
+> +notmuch_status_t\r
+> +notmuch_database_add_message_with_indexopts (notmuch_database_t *database,\r
+> +                                         const char *filename,\r
+> +                                         notmuch_indexopts_t *indexopts,\r
+> +                                         notmuch_message_t **message);\r
+>  \r
+\r
+I'm a bit surprised that no new return values are possible / documented\r
+here.\r
+\r
+d\r