gitweb: Harden and improve $project_filter page title
authorJakub Narebski <jnareb@gmail.com>
Sun, 12 Feb 2012 15:21:30 +0000 (16:21 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 13 Feb 2012 06:11:31 +0000 (22:11 -0800)
Commit 19d2d23 (gitweb: add project_filter to limit project list
to a subdirectory, 2012-01-30) added also support for displaying
$project_filter, if present, in page title.

Unfortunately it forgot to treat $project_filter as path, and escape
it using esc_path(), like it is done for $filename.

Also, it was not obvious that "$site_name - $project_filter" is about
project filtering: use "$site_name - projects in '$project_filter'".

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl

index f211594c4518949a6de27274a378092b3b59de75..877193f2829b8f79576843852bfe7544c5521f88 100755 (executable)
@@ -3742,7 +3742,7 @@ sub get_page_title {
 
        unless (defined $project) {
                if (defined $project_filter) {
-                       $title .= " - " . to_utf8($project_filter);
+                       $title .= " - projects in '" . esc_path($project_filter) . "'";
                }
                return $title;
        }