--- /dev/null
+Return-Path: <arhbkb@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id B7685431FD5\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Feb 2014 06:33:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.798\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id oX7rX7zthedG for <notmuch@notmuchmail.org>;\r
+ Sun, 2 Feb 2014 06:33:29 -0800 (PST)\r
+Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com\r
+ [74.125.82.52]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 984BA431FC0 for <notmuch@notmuchmail.org>; Sun, 2 Feb 2014 06:33:29 -0800\r
+ (PST)\r
+Received: by mail-wg0-f52.google.com with SMTP id b13so11025958wgh.7\r
+ for <notmuch@notmuchmail.org>; Sun, 02 Feb 2014 06:33:27 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+ :cc:content-type;\r
+ bh=MHErlIMsbHzoCUYuYb3QgDYBngTI73wZEWYWgT94zfA=;\r
+ b=tPdHAqAl2d3mzrtxIN6WvBSx1cSJwF8Ub+ADIuaSe7kc4GEmgFzFgQfZX39Iqc8gQa\r
+ E+CgD+PeiQGB+X0VsP4czWmTPprL84+VkQ8XHarUGv0204JPpXlH2sP2YF3fyfJU0auK\r
+ o07azybZuCiqjSrf6UI+wGDIzgrCT4FEjRhHmdJainKB6lpRVUqSfOs7zFOYVbIWVnXC\r
+ p6jXNET9hQSn+zKOi+0cjACIcTVru/h/fh5rcMXYJkZwqUuTAum2E+fwUI0ArG495+c6\r
+ DCvHTIw34wD/n1xU/nFM5UDSzj0nN2riCLzqoE03rQF7wlv8pH1VdGCU1GHk1OLqtefF\r
+ HUhg==\r
+MIME-Version: 1.0\r
+X-Received: by 10.180.80.103 with SMTP id q7mr5691560wix.14.1391351606915;\r
+ Sun, 02 Feb 2014 06:33:26 -0800 (PST)\r
+Received: by 10.227.2.9 with HTTP; Sun, 2 Feb 2014 06:33:26 -0800 (PST)\r
+In-Reply-To: <874n4hy8sa.fsf@nikula.org>\r
+References:\r
+ <CANbPJF=vD8VAhGKT_3udssvApbD_W644j=4o2H8h11xZjqPphA@mail.gmail.com>\r
+ <87a9e9yeta.fsf@nikula.org> <874n4hy8sa.fsf@nikula.org>\r
+Date: Sun, 2 Feb 2014 15:33:26 +0100\r
+Message-ID:\r
+ <CANbPJF=3+KpND6Fmhwuwer4hPBC6SKHM3C_dXr3xRzg8svk0uQ@mail.gmail.com>\r
+Subject: Re: bash completion error with 0.17\r
+From: Anand Buddhdev <arhbkb@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>\r
+Content-Type: multipart/alternative; boundary=f46d0442834c49b9a104f16d4afd\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Feb 2014 14:33:37 -0000\r
+\r
+--f46d0442834c49b9a104f16d4afd\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+\r
+Thanks Jani. I've just looked at the bash-completion formula on Homebrew.\r
+It says that bash-completion 2.0 and above needs bash4, but the current\r
+version of OSX, 10.9, still has bash 3.2, which is why, at least under\r
+Homebrew, we can't update bash-completion to the latest version.\r
+\r
+I think your patch probably makes sense. Once a user updates to a newer\r
+bash-completion, it will just begin working, while for users like me, the\r
+error message goes away.\r
+\r
+\r
+On 2 February 2014 13:54, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> On Sun, 02 Feb 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> > The trivial "fix" patch would likely just check for the existence of\r
+> > _init_completion, and refuse to complete without it. For anything\r
+> > fancier, patches welcome...\r
+>\r
+> The patch below would get rid of the error message (and completion, for\r
+> that matter) when _init_completion is not present.\r
+>\r
+> I'm not sure whether this is the way to go, or should we rather check\r
+> for a recent enough bash-completion during configure, or\r
+> recommend/suggest it, or what. The error message does tell us what's\r
+> wrong, although it's annoying for the user (probably more so than just\r
+> not completing).\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+>\r
+>\r
+> diff --git a/completion/notmuch-completion.bash\r
+> b/completion/notmuch-completion.bash\r
+> index 0f13204..0c457a8 100644\r
+> --- a/completion/notmuch-completion.bash\r
+> +++ b/completion/notmuch-completion.bash\r
+> @@ -384,6 +384,10 @@ _notmuch()\r
+> {\r
+> local _notmuch_commands="compact config count dump help insert new\r
+> reply restore search setup show tag"\r
+> local arg cur prev words cword split\r
+> +\r
+> + # require bash-completion with _init_completion\r
+> + type -t _init_completion >/dev/null 2>&1 || return\r
+> +\r
+> _init_completion || return\r
+>\r
+> COMPREPLY=()\r
+>\r
+\r
+--f46d0442834c49b9a104f16d4afd\r
+Content-Type: text/html; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<div dir=3D"ltr">Thanks Jani. I've just looked at the bash-completion f=\r
+ormula on Homebrew. It says that bash-completion 2.0 and above needs bash4,=\r
+ but the current version of OSX, 10.9, still has bash 3.2, which is why, at=\r
+ least under Homebrew, we can't update bash-completion to the latest ve=\r
+rsion.<div>\r
+<br></div><div>I think your patch probably makes sense. Once a user updates=\r
+ to a newer bash-completion, it will just begin working, while for users li=\r
+ke me, the error message goes away.</div></div><div class=3D"gmail_extra">\r
+<br><br><div class=3D"gmail_quote">On 2 February 2014 13:54, Jani Nikula <s=\r
+pan dir=3D"ltr"><<a href=3D"mailto:jani@nikula.org" target=3D"_blank">ja=\r
+ni@nikula.org</a>></span> wrote:<br><blockquote class=3D"gmail_quote" st=\r
+yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">\r
+<div class=3D"im">On Sun, 02 Feb 2014, Jani Nikula <<a href=3D"mailto:ja=\r
+ni@nikula.org">jani@nikula.org</a>> wrote:<br>\r
+> The trivial "fix" patch would likely just check for the exis=\r
+tence of<br>\r
+> _init_completion, and refuse to complete without it. For anything<br>\r
+> fancier, patches welcome...<br>\r
+<br>\r
+</div>The patch below would get rid of the error message (and completion, f=\r
+or<br>\r
+that matter) when _init_completion is not present.<br>\r
+<br>\r
+I'm not sure whether this is the way to go, or should we rather check<b=\r
+r>\r
+for a recent enough bash-completion during configure, or<br>\r
+recommend/suggest it, or what. The error message does tell us what's<br=\r
+>\r
+wrong, although it's annoying for the user (probably more so than just<=\r
+br>\r
+not completing).<br>\r
+<br>\r
+BR,<br>\r
+Jani.<br>\r
+<br>\r
+<br>\r
+<br>\r
+diff --git a/completion/notmuch-completion.bash b/completion/notmuch-comple=\r
+tion.bash<br>\r
+index 0f13204..0c457a8 100644<br>\r
+--- a/completion/notmuch-completion.bash<br>\r
++++ b/completion/notmuch-completion.bash<br>\r
+@@ -384,6 +384,10 @@ _notmuch()<br>\r
+=A0{<br>\r
+=A0 =A0 =A0local _notmuch_commands=3D"compact config count dump help i=\r
+nsert new reply restore search setup show tag"<br>\r
+=A0 =A0 =A0local arg cur prev words cword split<br>\r
++<br>\r
++ =A0 =A0# require bash-completion with _init_completion<br>\r
++ =A0 =A0type -t _init_completion >/dev/null 2>&1 || return<br>\r
++<br>\r
+=A0 =A0 =A0_init_completion || return<br>\r
+<br>\r
+=A0 =A0 =A0COMPREPLY=3D()<br>\r
+</blockquote></div><br></div>\r
+\r
+--f46d0442834c49b9a104f16d4afd--\r
projects / notmuch-archives.git / commitdiff