Fixed a bug with the handling of empty statements in macros (it also fixes a bug...

--HG--
branch : trunk

diff --git a/CHANGES b/CHANGES
index 079d2fc668659960481048ebfb2da57bdb2aded8..af3ef4cafc67735a3de3bcb661fa0faa3831588f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -28,6 +28,8 @@ Version 2.1
 
 - added `sort` filter that works like `dictsort` but for arbitrary sequences.
 
+- fixed a bug with empty statements in macros.
+
 Version 2.0
 -----------
 (codename jinjavitus, released on July 17th 2008)

diff --git a/jinja2/compiler.py b/jinja2/compiler.py
index c63044ab0833e578358c46c44eb22459c7e2b814..f3b8d6dabc90bf1d6c97b53212c09f51a04b81e1 100644 (file)
--- a/jinja2/compiler.py
+++ b/jinja2/compiler.py
@@ -138,6 +138,10 @@ class Frame(object):
         # situations.
         self.rootlevel = False
 
+        # An extends statement flags the frame as silent if it occours.
+        # This is used to suppress unwanted output.
+        self.silent = False
+
         # inside some tags we are using a buffer rather than yield statements.
         # this for example affects {% filter %} or {% macro %}.  If a frame
         # is buffered this variable points to the name of the list used as
@@ -403,13 +407,15 @@ class CodeGenerator(NodeVisitor):
         self.write(s)
         self.end_write(frame)
 
-    def blockvisit(self, nodes, frame, force_generator=True):
+    def blockvisit(self, nodes, frame):
         """Visit a list of nodes as block in a frame.  If the current frame
         is no buffer a dummy ``if 0: yield None`` is written automatically
         unless the force_generator parameter is set to False.
         """
-        if frame.buffer is None and force_generator:
+        if frame.buffer is None:
             self.writeline('if 0: yield None')
+        else:
+            self.writeline('pass')
         try:
             for node in nodes:
                 self.visit(node, frame)
@@ -751,6 +757,7 @@ class CodeGenerator(NodeVisitor):
         if not frame.toplevel:
             self.fail('cannot use extend from a non top-level scope',
                       node.lineno)
+        frame.silent = True
 
         # if the number of extends statements in general is zero so
         # far, we don't have to add a check if something extended
@@ -975,7 +982,7 @@ class CodeGenerator(NodeVisitor):
             self.outdent(2)
 
         self.indent()
-        self.blockvisit(node.body, loop_frame, force_generator=True)
+        self.blockvisit(node.body, loop_frame)
         if node.else_:
             self.writeline('%s = 0' % iteration_indicator)
         self.outdent()
@@ -983,7 +990,7 @@ class CodeGenerator(NodeVisitor):
         if node.else_:
             self.writeline('if %s:' % iteration_indicator)
             self.indent()
-            self.blockvisit(node.else_, loop_frame, force_generator=False)
+            self.blockvisit(node.else_, loop_frame)
             self.outdent()
 
         # reset the aliases if there are any.
@@ -1039,7 +1046,7 @@ class CodeGenerator(NodeVisitor):
         aliases = self.collect_shadowed(filter_frame)
         self.pull_locals(filter_frame)
         self.buffer(filter_frame)
-        self.blockvisit(node.body, filter_frame, force_generator=False)
+        self.blockvisit(node.body, filter_frame)
         self.start_write(frame, node)
         self.visit_Filter(node.filter, filter_frame)
         self.end_write(frame)
@@ -1051,7 +1058,8 @@ class CodeGenerator(NodeVisitor):
 
     def visit_Output(self, node, frame):
         # if we have a known extends statement, we don't output anything
-        if self.has_known_extends and frame.block is None:
+        # if we are in a silent section
+        if self.has_known_extends and frame.silent:
             return
 
         if self.environment.finalize:
@@ -1065,7 +1073,7 @@ class CodeGenerator(NodeVisitor):
         # statement we have to add a check that disables our yield(s) here
         # so that they don't appear in the output.
         outdent_later = False
-        if frame.block is None and self.extends_so_far != 0:
+        if frame.silent and self.extends_so_far != 0:
             self.writeline('if parent_template is None:')
             self.indent()
             outdent_later = True