Re: [PATCH v3] nmbug: Translate to Python

diff --git a/ae/e1d867c26f20fe0c03839d7ef73adabbb1a4e3 b/ae/e1d867c26f20fe0c03839d7ef73adabbb1a4e3
new file mode 100644 (file)
index 0000000..843b21c
--- /dev/null
+++ b/ae/e1d867c26f20fe0c03839d7ef73adabbb1a4e3
@@ -0,0 +1,125 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5E201431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Aug 2014 17:14:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lusK2EocsODv for <notmuch@notmuchmail.org>;\r
+       Mon,  4 Aug 2014 17:14:52 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A70CF431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Aug 2014 17:14:52 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XESOx-0000KB-8O; Mon, 04 Aug 2014 21:14:51 -0300\r
+Received: (nullmailer pid 9215 invoked by uid 1000); Tue, 05 Aug 2014\r
+       00:14:46 -0000\r
+From: David Bremner <bremner@debian.org>\r
+To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3] nmbug: Translate to Python\r
+In-Reply-To:\r
+ <84447a0ed48412e1587761d560d18cb5affd4f66.1405897133.git.wking@tremily.us>\r
+References:\r
+ <84447a0ed48412e1587761d560d18cb5affd4f66.1405897133.git.wking@tremily.us>\r
+User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 04 Aug 2014 21:14:46 -0300\r
+Message-ID: <878un36bd5.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Aug 2014 00:14:58 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+\r
+> * Commands are no longer split into "most common", "other useful", and\r
+>   "less common" sets.  If we need something like this, I'd prefer\r
+>   workflow examples highlighting common commands in the module\r
+>   docstring (available with 'nmbug --help').\r
+>\r
+\r
+I don't feel strongly about this, but I remember implementing it by\r
+request in the first version. OTOH, I think you shortened up the main\r
+help string when you split it.  We may want to think about a seperate\r
+man page as a follow project.\r
+\r
+One thing I did notice is that there is no hint to call \r
+nmbug {command} --help in the main docstring.\r
+\r
+\r
+> +#!/usr/bin/env python\r
+> +# Copyright (c) 2011 David Bremner\r
+> +# License: same as notmuch\r
+\r
+You should add your self, update the date, and probably explicitly \r
+state the license, as in Carl's patch for nmbug-status.\r
+\r
+\r
+> +__version__ = '0.2'\r
+\r
+Do we need/want a version distinct from that of notmuch?\r
+\r
+\r
+> +def _hex_quote(string, safe='+@=:,'):\r
+\r
+I'm not sure I really understand what makes a function/variable\r
+"private" and hence prefixed with _ in your translation.\r
+\r
+\r
+> +    status, tree, stderr = _git(\r
+\r
+as a non-native speaker of python, I find this a bit hard to read.  How\r
+about adding some parens to make the multiple return more clear, so\r
+\r
+    (status, tree, stderr) = _git(\r
+\r
+\r
+> +        for id, tags in status['deleted'].items():\r
+same comment here.\r
+\r
+> +\r
+> +def merge(reference='@{upstream}'):\r
+> +    """\r
+\r
+I did notice that merging was noticably noisier than I remembered. \r
+\r
+\r
+> +    output = _collections.defaultdict(\r
+> +        lambda : _collections.defaultdict( # {tag: status_string}\r
+> +            lambda : ' '))  # default local status\r
+\r
+The initial comment is confusing (to me) because it looks like code.\r
+The two layers of defaultdict are a bit confusing too; it would help to\r
+mention the key of the outer dictionary.\r
+\r
+I guess it makes sense to go for a relatively straight translation as a\r
+first step; I did wonder about whether using the python bindings to\r
+notmuch would speed things up.  Any ideas about how to even figure out\r
+where the bottlenecks are?\r
+\r
+d\r
+\r
+\r
+\r