ui.cli: Remove explicit return from QuestionCommandLine._extra_ps1_lines()
authorW. Trevor King <wking@tremily.us>
Sat, 23 Mar 2013 12:08:40 +0000 (08:08 -0400)
committerW. Trevor King <wking@tremily.us>
Sat, 23 Mar 2013 12:08:40 +0000 (08:08 -0400)
Mixing return statements and `yield`-based generators is bad practice.

quizzer/ui/cli.py

index ba26b328fd66179d2c59615050e5529335788571..763e3a71c7ddd79a1991a09cebd94a325e5d23a8 100644 (file)
@@ -100,7 +100,6 @@ class QuestionCommandLine (_cmd.Cmd):
                 self._separator = ','
                 yield ("Separate multiple answers with the '{}' character"
                        ).format(self._separator)
-        return []
 
     def _process_answer(self, answer):
         "Back out any mappings suggested by _extra_ps1_lines()"