[notmuch] [PATCH] Nuke the remainings of _notmuch_message_add_thread_id.

diff --git a/c4/b6a21584b4ac298ca7b7ac8a698f82ec1635ae b/c4/b6a21584b4ac298ca7b7ac8a698f82ec1635ae
new file mode 100644 (file)
index 0000000..4818e67
--- /dev/null
+++ b/c4/b6a21584b4ac298ca7b7ac8a698f82ec1635ae
@@ -0,0 +1,107 @@
+Return-Path: <fcarrijo@yahoo.com.br>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DF1F7431FBD\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Dec 2009 11:09:06 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id I6G5tez2wLao for <notmuch@notmuchmail.org>;\r
+       Wed,  9 Dec 2009 11:09:06 -0800 (PST)\r
+Received: from n21.bullet.mail.mud.yahoo.com (n21.bullet.mail.mud.yahoo.com\r
+       [68.142.206.160])\r
+       by olra.theworths.org (Postfix) with SMTP id 2A3EC431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Dec 2009 11:09:06 -0800 (PST)\r
+Received: from [68.142.200.226] by n21.bullet.mail.mud.yahoo.com with NNFMP;\r
+       09 Dec 2009 19:09:05 -0000\r
+Received: from [68.142.201.245] by t7.bullet.mud.yahoo.com with NNFMP;\r
+       09 Dec 2009 19:09:05 -0000\r
+Received: from [127.0.0.1] by omp406.mail.mud.yahoo.com with NNFMP;\r
+       09 Dec 2009 19:09:05 -0000\r
+X-Yahoo-Newman-Id: 697716.31531.bm@omp406.mail.mud.yahoo.com\r
+Received: (qmail 37591 invoked from network); 9 Dec 2009 19:09:05 -0000\r
+DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.br;\r
+       h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:Message-ID:MIME-Version:Content-Type;\r
+       b=RxkbrVWN6JJuc9S+enZ+lC2qiai87cNDRp+fJEut4UYmdvZS9Yn0uU3hAJH8WhBr3ZO9euaNBOY9zvJBodKyL5Wuz37JHvkv+jJ6mItqF24uhtLstkPSUQIoxqyX13HUpBVAKvnPWb7xXNNcpuUUgjeQhIE+IRrzZZRUOAhsHYc=  ; \r
+Received: from 189.27.100.158.dynamic.adsl.gvt.net.br (fcarrijo@189.27.100.158\r
+       with login)\r
+       by smtp141.mail.mud.yahoo.com with SMTP; 09 Dec 2009 11:09:05 -0800 PST\r
+X-Yahoo-SMTP: NgkT36eswBAymTD26_IxCjMQ0A5a\r
+X-YMail-OSG: l_x0eLYVM1nlLhxSA3td7W3.eYzSPVkejuNGmeFvcAIdbs.uGAQkKhMQMb8agMdffopGvmLyIf..DxiJ_PsAQkOfA8l0NqlgpMF1GSyUvhRkLAOYLg5oDmqWPbLtmwo2l5SuOaJu0RE6J6wvmQM7YKXT_i_HhJcGnsciK2GxkqSkEyg4l07XlJYQCDNCizQWfz5KA77Yi31QmKNfZoKASZTDuwp.3.BO7qcUPn72GvOU6f0t9KempoCuB9lO63h5jnexxVgizkjBzzx1s.tDb0TIeN2.veCc.iqda7YGaJqyC.p2Uvbrg.6nDS7f5FGl4Q--\r
+X-Yahoo-Newman-Property: ymail-3\r
+From: Fernando Carrijo <fcarrijo@yahoo.com.br>\r
+To: notmuch@notmuchmail.org\r
+Date: Wed, 09 Dec 2009 17:09:01 -0200\r
+Message-ID: <877hswyng2.fsf@yahoo.com.br>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: [notmuch] [PATCH] Nuke the remainings of\r
+       _notmuch_message_add_thread_id.\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 09 Dec 2009 19:09:07 -0000\r
+\r
+\r
+The function _notmuch_message_add_thread_id has been removed\r
+from the private interface of notmuch. There's no reason for\r
+one to keep a declaration of its prototype in the code base.\r
+Also, lets update a commentary that referenced that function\r
+and escaped from previous scrutiny.\r
+\r
+Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>\r
+---\r
+ lib/database.cc       |    9 ++++-----\r
+ lib/notmuch-private.h |    4 ----\r
+ 2 files changed, 4 insertions(+), 9 deletions(-)\r
+\r
+diff --git a/lib/database.cc b/lib/database.cc\r
+index 23ddd4a..b6c4d07 100644\r
+--- a/lib/database.cc\r
++++ b/lib/database.cc\r
+@@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch,\r
+  *\r
+  * We first look at 'message_file' and its link-relevant headers\r
+  * (References and In-Reply-To) for message IDs. We also look in the\r
+- * database for existing message that reference 'message'.p\r
++ * database for existing message that reference 'message'.\r
+  *\r
+- * The end result is to call _notmuch_message_add_thread_id with one\r
+- * or more thread IDs to which this message belongs, (including\r
+- * generating a new thread ID if necessary if the message doesn't\r
+- * connect to any existing threads).\r
++ * The end result is to call _notmuch_message_ensure_thread_id which\r
++ * generates a new thread ID if the message doesn't connect to any\r
++ * existing threads.\r
+  */\r
+ static notmuch_status_t\r
+ _notmuch_database_link_message (notmuch_database_t *notmuch,\r
+diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h\r
+index 0c340a7..116f63d 100644\r
+--- a/lib/notmuch-private.h\r
++++ b/lib/notmuch-private.h\r
+@@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message,\r
+                              const char *filename);\r
+ \r
+ void\r
+-_notmuch_message_add_thread_id (notmuch_message_t *message,\r
+-                              const char *thread_id);\r
+-\r
+-void\r
+ _notmuch_message_ensure_thread_id (notmuch_message_t *message);\r
+ \r
+ void\r
+-- \r
+1.5.6.3\r
+\r
+\r