--- /dev/null
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3DD29431FC2\r
+ for <notmuch@notmuchmail.org>; Sun, 1 Feb 2015 13:36:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.739\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.739 tagged_above=-999 required=5\r
+ tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7,\r
+ UNPARSEABLE_RELAY=0.001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id R5faG8f7dXet for <notmuch@notmuchmail.org>;\r
+ Sun, 1 Feb 2015 13:36:48 -0800 (PST)\r
+Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com\r
+ [209.85.212.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id C973A431FC0\r
+ for <notmuch@notmuchmail.org>; Sun, 1 Feb 2015 13:36:47 -0800 (PST)\r
+Received: by mail-wi0-f182.google.com with SMTP id n3so11728949wiv.3\r
+ for <notmuch@notmuchmail.org>; Sun, 01 Feb 2015 13:36:44 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
+ :from:date:message-id:mime-version:content-type\r
+ :content-transfer-encoding;\r
+ bh=lS45ESyXyQKWixJwLecJJWKGC4JU5cJh39Z7jrQKYF4=;\r
+ b=jePytW8+KXeKXMC3T43SMGEVXxufV0egvlSTACbz90kNJu4Lb6/xfD9Td+j5MlgSLP\r
+ eIO7vQr6uNsdC2vUtiQ6n8ymXpy9sIP2+vYBf77Wbav76yMc9sGXY1ozSiCIVrEJDtM7\r
+ aSpCGqtdRGKenrDkGjzfo+xseqtfs5kU7SrJo7B2H1DzEErd5XCRAFOPIg6aXzKs1ATw\r
+ 0yd4gzz9q06LA8/qfhgBdNOGhQqODtkZX5nmF2YsDhMhsW09+p8zf7SAIRfui4t3Km6I\r
+ BgDHgkJ593C2KEbTJqVOWalody/u46R/UTsq33uyQ8on8H13PXXoh3ENDqWFl5C79Wa5\r
+ 9cxQ==\r
+X-Gm-Message-State:\r
+ ALoCoQlCRqcS9NSofKjNhBQ+4h/1BRkoAxUDt8O2gCKEMJX+e9X6lCsIz6lenju0bvq2J+P19cHv\r
+X-Received: by 10.180.198.148 with SMTP id jc20mr12584892wic.67.1422826603393;\r
+ Sun, 01 Feb 2015 13:36:43 -0800 (PST)\r
+Received: from disaster-area.hh.sledj.net\r
+ ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
+ by mx.google.com with ESMTPSA id d7sm24922070wjs.2.2015.02.01.13.36.41\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Sun, 01 Feb 2015 13:36:42 -0800 (PST)\r
+Received: from localhost (30000@localhost [local]);\r
+ by localhost (OpenSMTPD) with ESMTPA id 7e17e347;\r
+ Sun, 1 Feb 2015 21:36:40 +0000 (UTC)\r
+To: Jinwoo Lee <jinwoo68@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Add a defcustom that specifies regexp for\r
+ blocked remote images.\r
+In-Reply-To: <1422567352-32647-1-git-send-email-jinwoo68@gmail.com>\r
+References: <1422567352-32647-1-git-send-email-jinwoo68@gmail.com>\r
+User-Agent: none\r
+From: David Edmondson <dme@dme.org>\r
+Date: Sun, 01 Feb 2015 21:36:40 +0000\r
+Message-ID: <cunlhkhe2l3.fsf@fenchurch.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 01 Feb 2015 21:36:51 -0000\r
+\r
+On Thu, Jan 29 2015, Jinwoo Lee wrote:\r
+> It's default value is ".", meaning all remote images will be blocked\r
+> by default.\r
+>\r
+> ---\r
+> This time setting gnus-blocked-images from the correct place.\r
+\r
+Looks good - it is better than the code currently in the repository,\r
+even if it doesn=E2=80=99t address every possible case that we have discuss=\r
+ed.\r
+\r
+> ---\r
+> emacs/notmuch-show.el | 23 ++++++++++++++++++-----\r
+> 1 file changed, 18 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 66350d4..6f38e0c 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -136,6 +136,11 @@ indentation."\r
+> :type 'boolean\r
+> :group 'notmuch-show)\r
+>=20=20\r
+> +(defcustom notmuch-show-text/html-blocked-images "."\r
+> + "Remote images that have URLs matching this regexp will be blocked."\r
+> + :type '(choice (const nil) regexp)\r
+> + :group 'notmuch-show)\r
+> +\r
+> (defvar notmuch-show-thread-id nil)\r
+> (make-variable-buffer-local 'notmuch-show-thread-id)\r
+> (put 'notmuch-show-thread-id 'permanent-local t)\r
+> @@ -798,16 +803,24 @@ will return nil if the CID is unknown or cannot be =\r
+retrieved."\r
+> ;; URL-decode it (see RFC 2392).\r
+> (let ((cid (url-unhex-string url)))\r
+> (first (notmuch-show--get-cid-content cid)))))\r
+> - ;; Block all external images to prevent privacy leaks and\r
+> - ;; potential attacks. FIXME: If we block an image, offer a\r
+> - ;; button to load external images.\r
+> - (shr-blocked-images "."))\r
+> + ;; By default, block all external images to prevent privacy\r
+> + ;; leaks and potential attacks. FIXME: If we block an image,\r
+> + ;; offer a button to load external images.\r
+> + (shr-blocked-images notmuch-show-text/html-blocked-images))\r
+> (shr-insert-document dom)\r
+> t))\r
+>=20=20\r
+> (defun notmuch-show-insert-part-*/* (msg part content-type nth depth but=\r
+ton)\r
+> ;; This handler _must_ succeed - it is the handler of last resort.\r
+> - (notmuch-mm-display-part-inline msg part content-type notmuch-show-pro=\r
+cess-crypto)\r
+> +\r
+> + ;; By default, block all external images to prevent privacy leaks\r
+> + ;; and potential attacks. FIXME: If we block an image, offer a\r
+> + ;; button to load external images.\r
+> + ;; Note that GNUS-BLOCKED-IMAGES is effective only when\r
+> + ;; MM-TEXT-HTML-RENDERER is 'gnus-w3m.\r
+> + (let ((gnus-blocked-images notmuch-show-text/html-blocked-images))\r
+> + (notmuch-mm-display-part-inline msg part content-type\r
+> + notmuch-show-process-crypto))\r
+> t)\r
+>=20=20\r
+> ;; Functions for determining how to handle MIME parts.\r
+> --=20\r
+> 2.2.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff