Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

diff --git a/65/e232a157881f1e8ad0902036d0f673253b1276 b/65/e232a157881f1e8ad0902036d0f673253b1276
new file mode 100644 (file)
index 0000000..f6d6da1
--- /dev/null
+++ b/65/e232a157881f1e8ad0902036d0f673253b1276
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5B352431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 12 May 2013 04:20:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id doscuBKhrnIG for <notmuch@notmuchmail.org>;\r
+       Sun, 12 May 2013 04:20:12 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 585E9431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 12 May 2013 04:20:12 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4CBKASw029597;\r
+       Sun, 12 May 2013 08:20:10 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UbUK2-00035X-DN; Sun, 12 May 2013 08:20:10 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UbUJw-0002Me-P3; Sun, 12 May 2013 08:20:04 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t\r
+In-Reply-To: <1368301809-12532-8-git-send-email-markwalters1009@gmail.com>\r
+References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com>\r
+       <1368301809-12532-8-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 12 May 2013 08:20:04 -0300\r
+Message-ID: <87zjw0la1n.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 12 May 2013 11:20:18 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> -        notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE);\r
+> +        notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG);\r
+\r
+Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG?  I\r
+realize it is not _wrong_ as written, but it is a bit confusing not to\r
+cover all possible values of the enum.\r
+\r
+Other than that, the series LGTM.\r
+\r
+d\r