Re: [PATCH] VIM: Make an option to save sent mail locally

diff --git a/46/7b274a782a462e801ad3aa18115555aa045e1a b/46/7b274a782a462e801ad3aa18115555aa045e1a
new file mode 100644 (file)
index 0000000..51cf94a
--- /dev/null
+++ b/46/7b274a782a462e801ad3aa18115555aa045e1a
@@ -0,0 +1,130 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3C84F431FBF\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Oct 2014 02:53:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mrz72NNvojeF for <notmuch@notmuchmail.org>;\r
+       Sun, 19 Oct 2014 02:53:39 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0798B431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Oct 2014 02:53:39 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id B63CC10008C;\r
+       Sun, 19 Oct 2014 12:53:19 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ian Main <imain@stemwinder.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] VIM: Make an option to save sent mail locally\r
+In-Reply-To: <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>\r
+References: <1412617904-27252-1-git-send-email-imain@stemwinder.org>\r
+       <1412619036-29203-1-git-send-email-imain@stemwinder.org>\r
+       <m27g0dt5lk.fsf@guru.guru-group.fi>\r
+       <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 19 Oct 2014 12:53:19 +0300\r
+Message-ID: <m2mw8sbd2o.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 Oct 2014 09:53:46 -0000\r
+\r
+On Tue, Oct 07 2014, Ian Main <imain@stemwinder.org> wrote:\r
+\r
+> Tomi Ollila wrote:\r
+>> On Mon, Oct 06 2014, Ian Main <imain@stemwinder.org> wrote:\r
+>> \r
+>> > Add an option to use 'notmuch insert' to save your sent mail.\r
+>> > ---\r
+>> >\r
+>> > Add -inbox as well.\r
+>> >\r
+>> >  vim/notmuch.vim | 17 +++++++++++++++++\r
+>> >  1 file changed, 17 insertions(+)\r
+>> >\r
+>> > diff --git a/vim/notmuch.vim b/vim/notmuch.vim\r
+>> > index 331e930..a9044c4 100644\r
+>> > --- a/vim/notmuch.vim\r
+>> > +++ b/vim/notmuch.vim\r
+>> > @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y'\r
+>> >  let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S'\r
+>> >  let s:notmuch_reader_default = 'mutt -f %s'\r
+>> >  let s:notmuch_sendmail_default = 'sendmail'\r
+>> > +let s:notmuch_save_sent_locally_default = 1\r
+>> >  let s:notmuch_folders_count_threads_default = 0\r
+>> >  \r
+>> >  function! s:new_file_buffer(type, fname)\r
+>> > @@ -108,6 +109,18 @@ EOF\r
+>> >           echohl None\r
+>> >           return\r
+>> >   endif\r
+>> \r
+>> AFAIU looks mmm. readable ;)\r
+>> \r
+>> > +\r
+>> > + if g:notmuch_save_sent_locally\r
+>> > +         let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox')\r
+>> \r
+>> as this is (looks like) shell invocation, this could be in format\r
+>> \r
+>> let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)\r
+>\r
+> You are right, that's better.\r
+>\r
+>> or even \r
+>> \r
+>> let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)\r
+>> \r
+>> (well, the latter would be out of the status quo)\r
+>> \r
+>> Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes\r
+>> system() command lines use "notmuch" and sometimes g:notmuch_cmd \r
+>> -- I think the latter should be used in new code and the previous ones\r
+>> should be fixed.\r
+>> \r
+>> i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname)\r
+>> \r
+>> Totally untested from my part...\r
+>> \r
+>> When the change alike this lands to the notmuch repository this needs NEWS\r
+>> item which informs that from now sent mails are notmuch-inserted to\r
+>> user's mail store (as this seems to be the default...) -- well, let's see\r
+>> that when there are real reviewers (i.e. those who are interested to and can\r
+>> test this).\r
+>\r
+> Also a good suggestion.  From what I see they always use 'notmuch' straight up\r
+> which is probably a reasonable assumption.  I do think the actual init code for\r
+> vim could have a few more checks, such as verifying that 'notmuch' is in $PATH\r
+> etc. \r
+>\r
+> Thanks for the review!!  I'll send out a new rev tomorrow - very tired\r
+> right now.\r
+\r
+I never seen the new rev... :D\r
+\r
+>\r
+>     Ian\r
+\r
+Tomi\r