--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 9E612431FAF\r
+ for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 22:12:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id mQN9yDOGe07E for <notmuch@notmuchmail.org>;\r
+ Fri, 3 Feb 2012 22:12:14 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id B0705431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 22:12:13 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so4097351bke.26\r
+ for <notmuch@notmuchmail.org>; Fri, 03 Feb 2012 22:12:12 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type:content-transfer-encoding;\r
+ bh=pY1DfEV71xcyzBocBqO/60M7/nslxIo5zPkwH/0k5o8=;\r
+ b=VpfJz4ijjVdHWlThMjDJ2hafhiCHA8wcbPuGrecp1V6C/0xXqfsFUo1Mwf5fK2C/H5\r
+ heTGinbLwAW08k0cL28Zvl8I05CxNH7jP+WyrZUfbz5zLCjC9Nbx2GWhd/PTtE1zdaGf\r
+ YoxLRjv9ZHvVW7jzLj/3jY6aiU5f6seKTCOm4=\r
+Received: by 10.204.157.17 with SMTP id z17mr4731923bkw.37.1328335931023;\r
+ Fri, 03 Feb 2012 22:12:11 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id ek9sm23291155bkb.10.2012.02.03.22.12.10\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 03 Feb 2012 22:12:10 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages\r
+In-Reply-To:\r
+ <CAMoJFUsfPwmLPxhK_mCbJ7N66u5+62QQne-oNJjVawSUzfFrjg@mail.gmail.com>\r
+References: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca>\r
+ <CAMoJFUsfPwmLPxhK_mCbJ7N66u5+62QQne-oNJjVawSUzfFrjg@mail.gmail.com>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 04 Feb 2012 10:10:55 +0400\r
+Message-ID: <87obtfi0wg.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 06:12:14 -0000\r
+\r
+On Fri, 3 Feb 2012 23:01:23 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> w=\r
+rote:\r
+> Oh, and I just noticed that Dmitry has already fixed this, probably in\r
+> a better way [1] (though I maintain that there still may be a problem\r
+> with the approach in general). I clearly haven't been following the\r
+> list closely enough this week.\r
+>=20\r
+\r
+Yep, creating buttons for regions at the beginning of message is fixed.\r
+But I like the idea of not hiding the message if there is no text.\r
+Though, I think we should create the button, just not hide the text\r
+initially.\r
+\r
+This change would conflict with my fix, so we should probably wait until\r
+it is applied before working on this.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> [1] id:"1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com"\r
+>=20\r
+> On Fri, Feb 3, 2012 at 17:32, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrot=\r
+e:\r
+> > Hi everyone,\r
+> >\r
+> > I encountered today a bug that I remember being mentioned on IRC where\r
+> > some messages are shown in emacs as completely empty, even though their\r
+> > content is present and simple. For me, the bug shows up with messages t=\r
+hat\r
+> > have been forwarded by an Outlook user who didn't add any content to th=\r
+e top\r
+> > of the message. The first line of the message is "-----Original Message=\r
+-----",\r
+> > and the rest is the forwarded text. Notmuch tries to collapse the forwa=\r
+rded\r
+> > content into a button, but fails mysteriously.\r
+> >\r
+> > The first patch in this series adds a test (marked as broken) that demo=\r
+nstrates\r
+> > the bug. I think this should be pushed regardless of whether my solutio=\r
+n is\r
+> > the right one. My solution is to check whether we're collapsing the ent=\r
+ire\r
+> > message before doing so, and avoid turning it into a button if that's t=\r
+he case.\r
+> > I think this is a desirable behavior, since if someone has forwarded a =\r
+message\r
+> > without adding anything the user probably wants to read that message. B=\r
+ut,\r
+> > I'll admit that I didn't figure out the real cause of the problem, and I\r
+> > would be happy to hear other suggestions.\r
+> >\r
+> > It also occurs to me that this might indicate a bigger problem with how\r
+> > notmuch-wash.el handles messages starting with "-----Original Message--=\r
+---".\r
+> > Notmuch seems to assume that this indicates the rest of the message is =\r
+quoted\r
+> > stuff that's been top-posted on. In my office this isn't necessarily th=\r
+e case,\r
+> > since Outlook produces that line at the top of every reply, and it's up=\r
+ to\r
+> > the user whether to top-post or not (and not everyone does).\r
+> >\r
+> > I'll have to experiment a bit more to verify whether a problem (i.e. wh=\r
+ether\r
+> > Notmuch hides inappropriate things when someone replies inline with Out=\r
+look).\r
+> > Someone please correct me if I'm missing something in how the code oper=\r
+ates.\r
+> >\r
+> > Adam Wolfe Gordon (2):\r
+> > =C2=A0test: Add broken test for showing forwarded messages\r
+> > =C2=A0emacs: Fix broken showing of forwarded messages.\r
+> >\r
+> > =C2=A0emacs/notmuch-wash.el | =C2=A0 =C2=A05 +++--\r
+> > =C2=A0test/emacs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 32 +=\r
++++++++++++++++++++++++++++++++\r
+> > =C2=A02 files changed, 35 insertions(+), 2 deletions(-)\r
+> >\r
+> > --\r
+> > 1.7.5.4\r
+> >\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff