Re: bug report: Emacs notmuch-mode fails attachments with spaces

diff --git a/fc/4158495e77b5445facd0147322e32d1fd73b80 b/fc/4158495e77b5445facd0147322e32d1fd73b80
new file mode 100644 (file)
index 0000000..eda5248
--- /dev/null
+++ b/fc/4158495e77b5445facd0147322e32d1fd73b80
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8312B431FD6\r
+       for <notmuch@notmuchmail.org>; Fri, 20 Feb 2015 01:36:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UO0Igk1d6aJK for <notmuch@notmuchmail.org>;\r
+       Fri, 20 Feb 2015 01:36:32 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 390B6431FC9\r
+       for <notmuch@notmuchmail.org>; Fri, 20 Feb 2015 01:36:32 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id AD21E100090;\r
+       Fri, 20 Feb 2015 11:25:13 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: bug report: Emacs notmuch-mode fails attachments with spaces\r
+In-Reply-To: <m24mqs63ak.fsf@guru.guru-group.fi>\r
+References: <87twyurc78.fsf@dieweltistgarnichtso.net>\r
+       <m24mqu455x.fsf@guru.guru-group.fi>\r
+       <8761b9pu11.fsf@dieweltistgarnichtso.net>\r
+       <m24mqs63ak.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 20 Feb 2015 11:25:13 +0200\r
+Message-ID: <m2ioexorye.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 20 Feb 2015 09:36:35 -0000\r
+\r
+On Wed, Feb 11 2015, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+\r
+> On Tue, Feb 10 2015, Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net> wrote:\r
+>\r
+>> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+>> It seems to me that all of the following are true in this case:\r
+>>\r
+>> 1. Emacs executes the user's default shell to start zathura.\r
+>\r
+> That's stupid! it should run /bin/sh.\r
+>\r
+> I looked into emacs-23.1/lisp/gnus/mm-decode.el and while I could not\r
+> pinpoint the exact location where this shell command was invoked, I\r
+> found some similar code where emacs variable `shell-file-name` was used\r
+> (M-x describe-variable shell-file-name returns "/bin/zsh" for me).\r
+>\r
+> So, you could just test by (setq shell-file-name "/bin/sh") (or \r
+> just M-x set-variable shell-file-name /bin/sh in live emacs) and then\r
+> test whether those pdf:s open right.\r
+>\r
+> we cannot do much how (mm in) emacs escapes those variables (and why it\r
+> uses shell to execute that command line)...\r
+\r
+... but we could let-bind shell-file-name...\r
+\r
+>\r
+> Tomi\r
+>\r
+>>\r
+>> 2. For this, Emacs escapes the filename.\r
+>>\r
+>> 3. Emacs applies the wrong escaping to the filename. Note that single\r
+>>    quotes are interoperable between shells, while backslashes are not.\r
+>>\r
+>> 4. The rc(1) shell splits on spaces, as it knows no backslash escaping.\r
+>>\r
+>> 5. The shell executes zathura with three arguments, all bogus filenames.\r
+>>\r
+>> I cannot pinpoint where all this is happening, but I would suggest to\r
+>> just execve() zathura with a single unescaped filename as its argument.\r
+>>\r
+>> Greetings,\r
+>> -- \r
+>> Nils Dagsson Moskopp // erlehmann\r