Re: [PATCH] lib: reword comment about XFOLDER: prefix

diff --git a/54/31baf4e25edaf73d56cf86343733f52e2b92f4 b/54/31baf4e25edaf73d56cf86343733f52e2b92f4
new file mode 100644 (file)
index 0000000..469cbf6
--- /dev/null
+++ b/54/31baf4e25edaf73d56cf86343733f52e2b92f4
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 7CA1B6DE0A73\r
+ for <notmuch@notmuchmail.org>; Fri, 19 Aug 2016 05:18:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.007\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 8JEOZzGNy2MJ for <notmuch@notmuchmail.org>;\r
+ Fri, 19 Aug 2016 05:18:56 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id ABAD56DE098A\r
+ for <notmuch@notmuchmail.org>; Fri, 19 Aug 2016 05:18:56 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bailM-0000pt-MZ; Fri, 19 Aug 2016 08:19:04 -0400\r
+Received: (nullmailer pid 14580 invoked by uid 1000);\r
+ Fri, 19 Aug 2016 12:18:51 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: reword comment about XFOLDER: prefix\r
+In-Reply-To: <1471508311-21806-1-git-send-email-david@tethera.net>\r
+References: <1471508096-19252-1-git-send-email-david@tethera.net>\r
+ <1471508311-21806-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 19 Aug 2016 09:18:51 -0300\r
+Message-ID: <87k2fdq7dg.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.22\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Aug 2016 12:18:57 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> I believe the current one is misleading, because in my experiments\r
+> Xapian did not add : when prefix and term were both upper case. Indeed,\r
+> it's hard to see how it could, because prefixes are added at a layer\r
+> above Xapian in our code. See _notmuch_message_add_term for an example.\r
+>\r
+> Also try to explain why this is a good idea.  As far as I can ascertain,\r
+> this is more of an issue for a system trying to work with an unknown set\r
+> of prefixes. Since notmuch has a fixed set of prefixes, and we can\r
+> hopefully be trusted not to add XGOLD and XGOLDEN as prefixes, it is\r
+> harder for problems to arise.\r
+\r
+pushed,\r
+\r
+d\r