Re: [PATCH 5/5] completion: complete addresses in from:/to: search terms

diff --git a/d6/6506d170af8449689ce91272b8b982f5c76d1e b/d6/6506d170af8449689ce91272b8b982f5c76d1e
new file mode 100644 (file)
index 0000000..d3f1ab7
--- /dev/null
+++ b/d6/6506d170af8449689ce91272b8b982f5c76d1e
@@ -0,0 +1,134 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A3F72431FC2\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 23:20:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5N5qeBWXL5Nz for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Feb 2015 23:20:37 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 52C70431FC0\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 23:20:37 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4F7D210019F\r
+       for <notmuch@notmuchmail.org>; Tue, 24 Feb 2015 09:12:24 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 5/5] completion: complete addresses in from:/to: search\r
+       terms\r
+In-Reply-To: <1422388098-16333-5-git-send-email-jani@nikula.org>\r
+References: <1422388098-16333-1-git-send-email-jani@nikula.org>\r
+       <1422388098-16333-5-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 24 Feb 2015 09:12:24 +0200\r
+Message-ID: <m2fv9vhjfr.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 Feb 2015 07:20:40 -0000\r
+\r
+On Tue, Jan 27 2015, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> Use the new notmuch address command to do completion for addresses in\r
+> from: and to:.\r
+>\r
+> ---\r
+>\r
+> This patch is more of an RFC. The to: completion is sloooow because\r
+> typically there are more matches to begin with, and then producing the\r
+> results requires reading the messages. Maybe it would be better to use\r
+> the same mechanism as from: for both, even if it's not accurate for\r
+> to:?\r
+\r
+Shameless marketing puff: Imagine how fast would it would be to use\r
+nottoomuch-addresses -- the completions are there before one\r
+sees TAB KeyRelease event... ;)\r
+\r
+Tomi\r
+\r
+\r
+> ---\r
+>  completion/notmuch-completion.bash | 30 +++++++++++++++++++++++++-----\r
+>  1 file changed, 25 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash\r
+> index e0498903f22f..db49294fc58c 100644\r
+> --- a/completion/notmuch-completion.bash\r
+> +++ b/completion/notmuch-completion.bash\r
+> @@ -27,10 +27,30 @@\r
+>  # on completion.\r
+>  #\r
+>  \r
+> -_notmuch_user_emails()\r
+> +# $1: current input of the form prefix:partialinput, where prefix is\r
+> +# to or from.\r
+> +_notmuch_email()\r
+>  {\r
+> -    notmuch config get user.primary_email\r
+> -    notmuch config get user.other_email\r
+> +    local output prefix cur\r
+> +\r
+> +    prefix="${1%%:*}"\r
+> +    cur="${1#*:}"\r
+> +\r
+> +    # Cut the input to be completed at punctuation because\r
+> +    # (apparently) Xapian does not support the trailing wildcard '*'\r
+> +    # operator for input with punctuation. We let compgen handle the\r
+> +    # extra filtering required.\r
+> +    cur="${cur%%[^a-zA-Z0-9]*}"\r
+> +\r
+> +    case "$prefix" in\r
+> +    to) output=recipients;;\r
+> +    from) output=sender;;\r
+> +    *) return;;\r
+> +    esac\r
+> +\r
+> +    # Only emit plain, lower case, unique addresses.\r
+> +    notmuch address --output=$output $prefix:"${cur}*" | \\r
+> +    sed 's/[^<]*<\([^>]*\)>/\1/' | tr "[:upper:]" "[:lower:]" | sort -u\r
+>  }\r
+>  \r
+>  _notmuch_search_terms()\r
+> @@ -44,10 +64,10 @@ _notmuch_search_terms()\r
+>          COMPREPLY=( $(compgen -P "tag:" -W "`notmuch search --output=tags \*`" -- ${cur##tag:}) )\r
+>          ;;\r
+>      to:*)\r
+> -        COMPREPLY=( $(compgen -P "to:" -W "`_notmuch_user_emails`" -- ${cur##to:}) )\r
+> +        COMPREPLY=( $(compgen -P "to:" -W "`_notmuch_email ${cur}`" -- ${cur##to:}) )\r
+>          ;;\r
+>      from:*)\r
+> -        COMPREPLY=( $(compgen -P "from:" -W "`_notmuch_user_emails`" -- ${cur##from:}) )\r
+> +        COMPREPLY=( $(compgen -P "from:" -W "`_notmuch_email ${cur}`" -- ${cur##from:}) )\r
+>          ;;\r
+>      path:*)\r
+>          local path=`notmuch config get database.path`\r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r