Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

diff --git a/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853 b/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853
new file mode 100644 (file)
index 0000000..a1fb018
--- /dev/null
+++ b/8b/8fe8c35a2f4bb944efa50b26fb77234cea5853
@@ -0,0 +1,79 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 799FB431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  8 Mar 2013 04:05:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nKSqg+eq-NCq for <notmuch@notmuchmail.org>;\r
+       Fri,  8 Mar 2013 04:05:50 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 84639431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  8 Mar 2013 04:05:50 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UDw3S-0008HS-Lr; Fri, 08 Mar 2013 08:05:46 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UDw3J-0005Pg-T8; Fri, 08 Mar 2013 08:05:33 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 5/6] cli: move config open/close to main() from\r
+       subcommands\r
+In-Reply-To:\r
+ <75b8b04e4d63d67ec79ffe2379829add96b37be0.1362347362.git.jani@nikula.org>\r
+References: <cover.1362347362.git.jani@nikula.org>\r
+       <75b8b04e4d63d67ec79ffe2379829add96b37be0.1362347362.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org)\r
+       Emacs/24.3.50.1 (x86_64-pc-linux-gnu)\r
+Date: Fri, 08 Mar 2013 08:05:33 -0400\r
+Message-ID: <87obeuaygi.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 08 Mar 2013 12:05:54 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> This allows specifying config file as a top level argument to notmuch,\r
+> and generally makes it possible to override config file options in\r
+> main(), without having to touch the subcommands.\r
+>\r
+\r
+I pushed patchs 5 through 7 of this 6 patch series.\r
+\r
+- I'll see if I can figure out the elisp needed to work around the\r
+  "Tramp stomped on my environment variables" problem.\r
+\r
+- Is this NEWS worthy? \r
+\r
+- What about a unit test?\r
+\r
+- What about updating the tests to use this feature, is that a good idea? \r
+\r
+\r
+d\r