--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 494E1431FC0\r
+ for <notmuch@notmuchmail.org>; Sat, 4 Jan 2014 04:46:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+ tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id RNHtIL1Bi828 for <notmuch@notmuchmail.org>;\r
+ Sat, 4 Jan 2014 04:46:39 -0800 (PST)\r
+Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com\r
+ [209.85.220.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 672FE431FBD\r
+ for <notmuch@notmuchmail.org>; Sat, 4 Jan 2014 04:46:39 -0800 (PST)\r
+Received: by mail-pa0-f51.google.com with SMTP id fa1so16878769pad.10\r
+ for <notmuch@notmuchmail.org>; Sat, 04 Jan 2014 04:46:37 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:mime-version:in-reply-to:references:date\r
+ :message-id:subject:from:to:cc:content-type;\r
+ bh=JtSa5qOKFXCZ/rkmDJn8clo+cswnzCqKUs59YmhGYp4=;\r
+ b=KthG+TaUgaROCkXaGKNjO6EXnyeherW9uqoSmXF0nQfkgMPvAHHttZyjcIp4bN+qFe\r
+ IovriRb/BD5G9dc7VYHF8iO7dPafYTvmNpvahqv/yCC3R794fxFZBgmnlSAQM5ofUtBY\r
+ aqnbZAVOzOyepnuB2vbdgGLcVsY64ZjOeG+ZJDBDWzZi5S07DtAWTy6bUBxuOqrqvmo+\r
+ WXSwuKF6iJeWKrZGQYD2W9PdlaArCpXxmACHH1DjjZpMlaC7qRMfw0yj9VyJrd/+wvSw\r
+ Gq/N46KXnqxXOKdnz3f8uRK3sHQwnHRqv4bI+obTrcUyJbFV5GC6tG2GzZ2yxFM6l1cO\r
+ DdAg==\r
+X-Gm-Message-State:\r
+ ALoCoQlWHuEZZM7CymHHw0MUVGpglcot2ZWhLJ03Qfyn7MfCBrp20Z7+fFiTeLpRdD0umBoMozYM\r
+MIME-Version: 1.0\r
+X-Received: by 10.68.99.226 with SMTP id et2mr56822556pbb.8.1388839597368;\r
+ Sat, 04 Jan 2014 04:46:37 -0800 (PST)\r
+Received: by 10.70.42.228 with HTTP; Sat, 4 Jan 2014 04:46:37 -0800 (PST)\r
+Received: by 10.70.42.228 with HTTP; Sat, 4 Jan 2014 04:46:37 -0800 (PST)\r
+In-Reply-To:\r
+ <CAB+hUn-8eyY07y3j1N3JJLQ3qWVEVPoGWHcUVkovg34xH0ZOwQ@mail.gmail.com>\r
+References: <20140103214735.GG27614@danbala.tuwien.ac.at>\r
+ <CAB+hUn-8eyY07y3j1N3JJLQ3qWVEVPoGWHcUVkovg34xH0ZOwQ@mail.gmail.com>\r
+Date: Sat, 4 Jan 2014 14:46:37 +0200\r
+Message-ID:\r
+ <CAB+hUn-ov+2roT-tVTcjuPbckiTkRPtUxazfmY1KFeeVoMQJCA@mail.gmail.com>\r
+Subject: Re: notmuch-0.16: realpath() compatibility issue;\r
+ clang visibility problem\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Thomas Klausner <tk@giga.or.at>\r
+Content-Type: multipart/alternative; boundary=047d7b6dd09cda0cb204ef246ae9\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Jan 2014 12:46:47 -0000\r
+\r
+--047d7b6dd09cda0cb204ef246ae9\r
+Content-Type: text/plain; charset=UTF-8\r
+\r
+I guess we should look at realpath() compatibility, but in fairness passing\r
+NULL for the second parameter is according to POSIX.1-2008, not glibc\r
+extension.\r
+\r
+On Jan 4, 2014 2:35 PM, "Jani Nikula" <jani@nikula.org> wrote:\r
+>\r
+> For the visibility issue please upgrade Notmuch.\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+> On Jan 4, 2014 2:26 PM, "Thomas Klausner" <tk@giga.or.at> wrote:\r
+> >\r
+> > Hi!\r
+> >\r
+> > I'm currently starting to try out notmuch-0.16 on NetBSD. It went off\r
+> > to a rocky start, since it segfaulted in the initial config setup.\r
+> >\r
+> > Debugging it I found that notmuch uses a glibc extension to realpath,\r
+> > allowing NULL as second argument.\r
+> >\r
+> > I've converted it to use a prepared buffer instead; attached is a\r
+> > possible patch that makes notmuch complete its setup phase for me, and\r
+> > adds inclusion of the header files suggested by the realpath man page\r
+> > on NetBSD. Please address this issue in some way in the next release.\r
+> >\r
+> > Additionally, when compiling with clang, there are issues with the\r
+> > visibility. The symptoms are:\r
+> >\r
+> > In file included from lib/database.cc:21:\r
+> > In file included from ./lib/database-private.h:33:\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match\r
+previous declaration\r
+> > array subscriptstruct visible _notmuch_string_list {\r
+> > ^\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'visible'\r
+> > # define visible __attribute__((visibility("default")))\r
+> > ^\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here\r
+> > #pragma GCC visibility push(hidden)\r
+> > ^\r
+> >\r
+> > In file included from lib/parse-time-vrp.cc:23:\r
+> > In file included from ./lib/database-private.h:33:\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match\r
+previous declaration\r
+> > struct visible _notmuch_string_list {\r
+> > ^\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'visible'\r
+> > # define visible __attribute__((visibility("default")))\r
+> > ^\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here\r
+> > #pragma GCC visibility push(hidden)\r
+> > ^\r
+> > 1 warning generated.\r
+> > In file included from lib/directory.cc:21:\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match\r
+previous declaration\r
+> > struct visible _notmuch_string_list {\r
+> > ^\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'visible'\r
+> > # define visible __attribute__((visibility("default")))\r
+> > ^\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here\r
+> > #pragma GCC visibility push(hidden)\r
+> > ^\r
+> >\r
+> > and so on. I guess it is because the visibility differs between c and\r
+> > c++. I've disabled visibility locally, see second attached patch, but\r
+> > of course that's not a solution, just a workaround. Suggestions\r
+> > welcome.\r
+> >\r
+> > Thanks,\r
+> > Thomas\r
+> >\r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
+> >\r
+\r
+--047d7b6dd09cda0cb204ef246ae9\r
+Content-Type: text/html; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<p dir=3D"ltr">I guess we should look at realpath() compatibility, but in f=\r
+airness passing NULL for the second parameter is according to POSIX.1-2008,=\r
+ not glibc extension.<br></p>\r
+<p dir=3D"ltr">On Jan 4, 2014 2:35 PM, "Jani Nikula" <<a href=\r
+=3D"mailto:jani@nikula.org">jani@nikula.org</a>> wrote:<br>\r
+><br>\r
+> For the visibility issue please upgrade Notmuch.<br>\r
+><br>\r
+> BR,<br>\r
+> Jani.<br>\r
+><br>\r
+> On Jan 4, 2014 2:26 PM, "Thomas Klausner" <<a href=3D"mai=\r
+lto:tk@giga.or.at">tk@giga.or.at</a>> wrote:<br>\r
+> ><br>\r
+> > Hi!<br>\r
+> ><br>\r
+> > I'm currently starting to try out notmuch-0.16 on NetBSD. It =\r
+went off<br>\r
+> > to a rocky start, since it segfaulted in the initial config setup=\r
+.<br>\r
+> ><br>\r
+> > Debugging it I found that notmuch uses a glibc extension to realp=\r
+ath,<br>\r
+> > allowing NULL as second argument.<br>\r
+> ><br>\r
+> > I've converted it to use a prepared buffer instead; attached =\r
+is a<br>\r
+> > possible patch that makes notmuch complete its setup phase for me=\r
+, and<br>\r
+> > adds inclusion of the header files suggested by the realpath man =\r
+page<br>\r
+> > on NetBSD. Please address this issue in some way in the next rele=\r
+ase.<br>\r
+> ><br>\r
+> > Additionally, when compiling with clang, there are issues with th=\r
+e<br>\r
+> > visibility. The symptoms are:<br>\r
+> ><br>\r
+> > In file included from lib/database.cc:21:<br>\r
+> > In file included from ./lib/database-private.h:33:<br>\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match p=\r
+revious declaration<br>\r
+> > array subscriptstruct visible _notmuch_string_list {<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br>\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'vis=\r
+ible'<br>\r
+> > =C2=A0# define visible __attribute__((visibility("default&qu=\r
+ot;)))<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =\r
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here<b=\r
+r>\r
+> > #pragma GCC visibility push(hidden)<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> ><br>\r
+> > In file included from lib/parse-time-vrp.cc:23:<br>\r
+> > In file included from ./lib/database-private.h:33:<br>\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match p=\r
+revious declaration<br>\r
+> > struct visible _notmuch_string_list {<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br>\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'vis=\r
+ible'<br>\r
+> > # define visible __attribute__((visibility("default")))=\r
+<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =\r
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here<b=\r
+r>\r
+> > #pragma GCC visibility push(hidden)<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> > 1 warning generated.<br>\r
+> > In file included from lib/directory.cc:21:<br>\r
+> > ./lib/notmuch-private.h:479:8: error: visibility does not match p=\r
+revious declaration<br>\r
+> > struct visible _notmuch_string_list {<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0^<br>\r
+> > ./lib/notmuch-private.h:67:33: note: expanded from macro 'vis=\r
+ible'<br>\r
+> > # define visible __attribute__((visibility("default")))=\r
+<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =\r
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here<b=\r
+r>\r
+> > #pragma GCC visibility push(hidden)<br>\r
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>\r
+> ><br>\r
+> > and so on. I guess it is because the visibility differs between c=\r
+ and<br>\r
+> > c++. I've disabled visibility locally, see second attached pa=\r
+tch, but<br>\r
+> > of course that's not a solution, just a workaround. Suggestio=\r
+ns<br>\r
+> > welcome.<br>\r
+> ><br>\r
+> > Thanks,<br>\r
+> > =C2=A0Thomas<br>\r
+> ><br>\r
+> > _______________________________________________<br>\r
+> > notmuch mailing list<br>\r
+> > <a href=3D"mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.or=\r
+g</a><br>\r
+> > <a href=3D"http://notmuchmail.org/mailman/listinfo/notmuch">http:=\r
+//notmuchmail.org/mailman/listinfo/notmuch</a><br>\r
+> ><br>\r
+</p>\r
+\r
+--047d7b6dd09cda0cb204ef246ae9--\r
projects / notmuch-archives.git / commitdiff