Re: [PATCH] test: fix compact backup / restore test

diff --git a/c8/598f07e295ddc46ec3585443da7a6ac88016b6 b/c8/598f07e295ddc46ec3585443da7a6ac88016b6
new file mode 100644 (file)
index 0000000..67c2c89
--- /dev/null
+++ b/c8/598f07e295ddc46ec3585443da7a6ac88016b6
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 60B12431FC3\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 07:57:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tNwyVCKu3Hx7 for <notmuch@notmuchmail.org>;\r
+       Sat,  2 Nov 2013 07:57:06 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4F72B431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 07:57:06 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VccdL-0006RQ-I7; Sat, 02 Nov 2013 11:57:03 -0300\r
+Received: (nullmailer pid 6639 invoked by uid 1000); Sat, 02 Nov 2013\r
+       14:56:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: fix compact backup / restore test\r
+In-Reply-To: <m2li172avu.fsf@guru.guru-group.fi>\r
+References: <1383350515-24320-1-git-send-email-david@tethera.net>\r
+       <m2li172avu.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 02 Nov 2013 11:56:58 -0300\r
+Message-ID: <87a9hmsvgl.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 02 Nov 2013 14:57:12 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Sat, Nov 02 2013, David Bremner <david@tethera.net> wrote:\r
+>\r
+>> It was looking in completely the wrong place for the backup and the\r
+>> (test) xapian database. Unfortunately test_begin_subtest hides the\r
+>> relevant errors.\r
+>> ---\r
+>\r
+> LGTM. It took me a while noticing that also ${TEST_TMPDIR}\r
+> was changed to ${MAIL_DIR}\r
+\r
+Globally it makes me a bit nervous to be doing destructive operations on\r
+${MAIL_DIR}, but that isn't specific to this patch. I wonder if it would\r
+be worth globally replacing the variable with something like\r
+TEST_MAIL_DIR just to make collision with user environment less\r
+likely. Or maybe it's enough just to be careful to override MAIL_DIR.\r
+\r
+d\r
+\r