* Fix stupid bug in date matching, patch from Roland Mas. Closes: #381132

* Added many unit tests for pagespec_match.

diff --git a/IkiWiki.pm b/IkiWiki.pm
index 3f2ffa4ce66609ece564fedd2d058547ec133bd3..d9559bde45936348c51b0965c4da6262f00a3a16 100644 (file)
--- a/IkiWiki.pm
+++ b/IkiWiki.pm
@@ -599,16 +599,15 @@ sub match_backlink ($$) { #{{{
 } #}}}
 
 sub match_creation_day ($$) { #{{{
-       return if (gmtime($pagectime{shift()}))[3] == shift;
+       return ((gmtime($pagectime{shift()}))[3] == shift);
 } #}}}
 
 sub match_creation_month ($$) { #{{{
-       return if (gmtime($pagectime{shift()}))[4] + 1 == shift;
+       return ((gmtime($pagectime{shift()}))[4] + 1 == shift);
 } #}}}
 
 sub match_creation_year ($$) { #{{{
-       return if (gmtime($pagectime{shift()}))[5] + 1900 == shift;
+       return ((gmtime($pagectime{shift()}))[5] + 1900 == shift);
 } #}}}
 
-
 1

diff --git a/debian/changelog b/debian/changelog
index 7f13a216791e1741c1a5f820c46e6a608f889055..b7965836322077ee5eec412acae635459f3bbd37 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,8 +2,10 @@ ikiwiki (1.14) UNRELEASED; urgency=low
 
   * Memoize pagespec translation, this speeds up a build of the ikiwiki tree
     by 10% or so.
+  * Fix stupid bug in date matching, patch from Roland Mas. Closes: #381132
+  * Added many unit tests for pagespec_match.
 
- -- Joey Hess <joeyh@debian.org>  Tue,  1 Aug 2006 23:35:13 -0400
+ -- Joey Hess <joeyh@debian.org>  Wed,  2 Aug 2006 11:31:52 -0400
 
 ikiwiki (1.13) unstable; urgency=low
 

diff --git a/t/pagespec_match.t b/t/pagespec_match.t
index 2a370a217119062aa13671e6c06bb0b2f4c2c2d6..1863b9cbabf550752646de2cc079ee9138c2ae3f 100755 (executable)
--- a/t/pagespec_match.t
+++ b/t/pagespec_match.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 use warnings;
 use strict;
-use Test::More tests => 25;
+use Test::More tests => 31;
 
 BEGIN { use_ok("IkiWiki"); }
 
@@ -25,6 +25,14 @@ ok(! IkiWiki::pagespec_match("foo", "link(quux)"));
 ok(IkiWiki::pagespec_match("bar", "backlink(foo)"));
 ok(! IkiWiki::pagespec_match("quux", "backlink(foo)"));
 
+$IkiWiki::pagectime{foo}=1154532692; # Wed Aug  2 11:26 EDT 2006
+ok(IkiWiki::pagespec_match("foo", "creation_year(2006)"), "year");
+ok(! IkiWiki::pagespec_match("foo", "creation_year(2005)"), "other year");
+ok(IkiWiki::pagespec_match("foo", "creation_month(8)"), "month");
+ok(! IkiWiki::pagespec_match("foo", "creation_month(9)"), "other month");
+ok(IkiWiki::pagespec_match("foo", "creation_day(2)"), "day");
+ok(! IkiWiki::pagespec_match("foo", "creation_day(3)"), "other day");
+
 # old style globlists
 ok(IkiWiki::pagespec_match("foo", "foo bar"), "simple list");
 ok(IkiWiki::pagespec_match("bar", "foo bar"), "simple list 2");