Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Sun, 24 Jan 2016 16:03:22 +0000 (11:03 +1900)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 23:20:56 +0000 (16:20 -0700)
b0/a07f4b107870d7d680a2646fbb434b3f0d8e59 [new file with mode: 0644]

diff --git a/b0/a07f4b107870d7d680a2646fbb434b3f0d8e59 b/b0/a07f4b107870d7d680a2646fbb434b3f0d8e59
new file mode 100644 (file)
index 0000000..767b8bd
--- /dev/null
@@ -0,0 +1,70 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 769E96DE0AC2\r
+ for <notmuch@notmuchmail.org>; Sun, 24 Jan 2016 08:03:25 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.094\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.094 tagged_above=-999 required=5\r
+ tests=[AWL=-0.094] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id trri_zIQ6VzL for <notmuch@notmuchmail.org>;\r
+ Sun, 24 Jan 2016 08:03:23 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A687C6DE02DA\r
+ for <notmuch@notmuchmail.org>; Sun, 24 Jan 2016 08:03:23 -0800 (PST)\r
+Received: from fifthhorseman.net (h-67-101-29-155.nycm.ny.dynamic.megapath.net\r
+ [67.101.29.155])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id 47713F991;\r
+ Sun, 24 Jan 2016 11:03:21 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 3EED320152; Sun, 24 Jan 2016 11:03:22 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available\r
+In-Reply-To: <m2r3h757a1.fsf@guru.guru-group.fi>\r
+References: <1453258369-7366-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1453258369-7366-7-git-send-email-dkg@fifthhorseman.net>\r
+ <m2r3h757a1.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.21+67~g41ad7ff (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 24 Jan 2016 11:03:22 -0500\r
+Message-ID: <877fiz7ynp.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 24 Jan 2016 16:03:25 -0000\r
+\r
+On Sun 2016-01-24 10:25:26 -0500, Tomi Ollila wrote:\r
+> On Wed, Jan 20 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:\r
+>> --- a/test/test-lib.sh\r
+>> +++ b/test/test-lib.sh\r
+>> @@ -85,6 +85,13 @@ unset GREP_OPTIONS\r
+>>  # For emacsclient\r
+>>  unset ALTERNATE_EDITOR\r
+>>  \r
+>> +# choose the preferred GnuPG binary:\r
+>> +if hash gpg2 2> /dev/null; then\r
+>\r
+> For consistency, instead of hash ... 2>/dev/null, use command -v >/dev/null\r
+\r
+gotcha, i found several other instances of "command -v $whatever >\r
+/dev/null" in the codebase already, so i'll stick with that.  updated in\r
+my local copy now.\r
+\r
+   --dkg\r