Re: [PATCH 00/11] Improve charset and cid: handling

diff --git a/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 b/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735
new file mode 100644 (file)
index 0000000..9e0424a
--- /dev/null
+++ b/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735
@@ -0,0 +1,91 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B7778431FBF\r
+       for <notmuch@notmuchmail.org>; Mon, 21 Apr 2014 13:26:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XItTH6wh9Zy0 for <notmuch@notmuchmail.org>;\r
+       Mon, 21 Apr 2014 13:26:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8535C431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 21 Apr 2014 13:26:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 7407A10008C;\r
+       Mon, 21 Apr 2014 23:26:14 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Improve charset and cid: handling\r
+In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.17+201~g56da2d6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 21 Apr 2014 23:26:14 +0300\r
+Message-ID: <m2eh0qtont.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 21 Apr 2014 20:26:30 -0000\r
+\r
+On Mon, Apr 21 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> I set out to quickly add support for cid: links in the shr renderer\r
+> and wound up making our charset handling more robust and rewriting our\r
+> content-ID handling.  The test introduced in patch 2 passes in all but\r
+> one really obscure case, but only because of many unwritten and\r
+> potentially fragile assumptions that Emacs and the CLI make about each\r
+> other.\r
+>\r
+> The first three patches could reasonably go in to 0.18.  The rest of\r
+> this series is certainly post-0.18, but I didn't want to lose track of\r
+> it.\r
+\r
+Patches 1-3 looks good and tests pass. I've also (suffessfully) used\r
+this 'no-conversion (although I don't remember why ;/ -- this conversion\r
+stuff is not something simple to comprehend...)\r
+\r
+So, +1 for getting 1-3 to 0.18.\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> This series comes in three stages.  Each depends on the earlier ones,\r
+> but each prefix makes sense on its own and could be pushed without the\r
+> later stages.\r
+>\r
+> Patch 1 is a simple clean up patch.\r
+>\r
+> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly\r
+> by splitting the broken `notmuch-get-bodypart-content' API into\r
+> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a\r
+> caller can explicitly convey their requirements.\r
+>\r
+> The remaining patches improve our content-ID handling and add support\r
+> for cid: links for shr.\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r