Re: [PATCH v3 06/10] cli: Introduce "notmuch address" command

diff --git a/66/8c643aa070e2edb19294437250b3bb8dcfeb7d b/66/8c643aa070e2edb19294437250b3bb8dcfeb7d
new file mode 100644 (file)
index 0000000..ce188e5
--- /dev/null
+++ b/66/8c643aa070e2edb19294437250b3bb8dcfeb7d
@@ -0,0 +1,128 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1EE03431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:50:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VxWAGAte-jxM for <notmuch@notmuchmail.org>;\r
+       Wed,  5 Nov 2014 12:50:06 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 84823431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:50:06 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id AFEC1100033;\r
+       Wed,  5 Nov 2014 22:49:29 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 06/10] cli: Introduce "notmuch address" command\r
+In-Reply-To: <1415147159-19946-7-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415147159-19946-7-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.2+169~g5bcdd1c (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 05 Nov 2014 22:49:29 +0200\r
+Message-ID: <m24mud1ig6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Nov 2014 20:50:14 -0000\r
+\r
+On Wed, Nov 05 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> This moves address-related functionality from search command to the\r
+> new address command. The implementation shares almost all code and\r
+> some command line options.\r
+>\r
+> Options --offset and --limit were intentionally not included in the\r
+> address command, because they refer to messages numbers, which users\r
+> do not see in the output. This could confuse users because, for\r
+> example, they could see more addresses in the output that what was\r
+> specified with --limit. This functionality can be correctly\r
+> reimplemented for address subcommand later.\r
+>\r
+> Also useless values of --exclude flag were not included in the address\r
+> command.\r
+>\r
+> This was inspired by a patch from Jani Nikula.\r
+> ---\r
+>  completion/notmuch-completion.bash | 42 ++++++++++++++++-\r
+>  completion/notmuch-completion.zsh  | 10 +++-\r
+>  doc/man1/notmuch-address.rst       | 89 ++++++++++++++++++++++++++++++++++++\r
+>  doc/man1/notmuch-search.rst        | 20 +-------\r
+>  doc/man1/notmuch.rst               |  7 +--\r
+>  notmuch-client.h                   |  3 ++\r
+>  notmuch-search.c                   | 93 +++++++++++++++++++++++++++-----------\r
+>  notmuch.c                          |  2 +\r
+>  8 files changed, 216 insertions(+), 50 deletions(-)\r
+>  create mode 100644 doc/man1/notmuch-address.rst\r
+>\r
+> [ nnn lines removed ]\r
+>\r
+> +\r
+> +int\r
+> +notmuch_address_command (notmuch_config_t *config, int argc, char *argv[])\r
+> +{\r
+> +    search_context_t *ctx = &search_context;\r
+> +    int opt_index, ret;\r
+> +\r
+> +    notmuch_opt_desc_t options[] = {\r
+> +    { NOTMUCH_OPT_KEYWORD_FLAGS, &ctx->output, "output", 'o',\r
+> +      (notmuch_keyword_t []){ { "sender", OUTPUT_SENDER },\r
+> +                              { "recipients", OUTPUT_RECIPIENTS },\r
+> +                              { 0, 0 } } },\r
+> +    { NOTMUCH_OPT_KEYWORD, &ctx->exclude, "exclude", 'x',\r
+> +      (notmuch_keyword_t []){ { "true", NOTMUCH_EXCLUDE_TRUE },\r
+> +                              { "false", NOTMUCH_EXCLUDE_FALSE },\r
+> +                              { 0, 0 } } },\r
+> +    { NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },\r
+> +    { 0, 0, 0, 0, 0 }\r
+> +    };\r
+> +\r
+> +    opt_index = parse_arguments (argc, argv, options, 1);\r
+> +    if (opt_index < 0)\r
+> +    return EXIT_FAILURE;\r
+> +\r
+> +    if (! ctx->output)\r
+> +    ctx->output = OUTPUT_SENDER | OUTPUT_RECIPIENTS;\r
+\r
+If no --output options are given, the default could be just\r
+to OUTPUT_SENDER (for the speed and as this behaviour is not documented) \r
+\r
+(this can be also addressed in later patch, provided that this\r
+functionality gets more "votes" from the community)\r
+\r
+Tomi\r
+\r
+> +\r
+> +    if (_notmuch_search_prepare (ctx, config,\r
+> +                             argc - opt_index, argv + opt_index))\r
+> +    return EXIT_FAILURE;\r
+> +\r
+> +    ret = do_search_messages (ctx);\r
+> +\r
+> +    _notmuch_search_cleanup (ctx);\r
+> +\r
+> +    return ret ? EXIT_FAILURE : EXIT_SUCCESS;\r
+> +}\r