Re: [PATCH 5/5] lib: Separate all phrases indexed by _notmuch_message_gen_terms

diff --git a/d5/466498eb210a0a14906d40b2ffc6ff33399b6a b/d5/466498eb210a0a14906d40b2ffc6ff33399b6a
new file mode 100644 (file)
index 0000000..b9efae2
--- /dev/null
+++ b/d5/466498eb210a0a14906d40b2ffc6ff33399b6a
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D7D21431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jun 2014 14:11:38 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id c3n6P7RIOsLb for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jun 2014 14:11:34 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D5FD6431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jun 2014 14:11:33 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WxN8g-0004c6-NA; Wed, 18 Jun 2014 18:11:26 -0300\r
+Received: (nullmailer pid 5527 invoked by uid 1000); Wed, 18 Jun 2014\r
+       21:11:23 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 5/5] lib: Separate all phrases indexed by\r
+       _notmuch_message_gen_terms\r
+In-Reply-To: <1402886434-16169-6-git-send-email-amdragon@mit.edu>\r
+References: <1402886434-16169-1-git-send-email-amdragon@mit.edu>\r
+       <1402886434-16169-6-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.18+13~g1adde01 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 18 Jun 2014 18:11:23 -0300\r
+Message-ID: <87fvj1gbyc.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jun 2014 21:11:39 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> This adds a 100 termpos gap between all phrases indexed by\r
+> _notmuch_message_gen_terms.  This fixes a bug where terms from the end\r
+> of one header and the beginning of another header could match together\r
+> in a single phrase and a separate bug where term positions of\r
+> un-prefixed terms overlapped.\r
+>\r
+> This fix only affects newly indexed messages.  Messages that are\r
+> already indexed won't benefit from this fix without re-indexing, but\r
+> the fix won't make things any worse for existing messages.\r
+\r
+The series looks OK to me. It took me a little while to understand the\r
+problem with multiple parts was that the term positions currently start\r
+from zero for each part. If you happen to be re-rolling the series for\r
+some other reason, maybe you could be more explicit about that. I\r
+wouldn't bother just for that though.\r
+\r
+d\r