Re: [PATCH 2/2] emacs: add function to resend message to new recipients

diff --git a/08/37cd7827989743f3ca841c3b7938d71bbc570e b/08/37cd7827989743f3ca841c3b7938d71bbc570e
new file mode 100644 (file)
index 0000000..b18ec40
--- /dev/null
+++ b/08/37cd7827989743f3ca841c3b7938d71bbc570e
@@ -0,0 +1,107 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A90FD6DE0B2F\r
+ for <notmuch@notmuchmail.org>; Mon, 31 Aug 2015 12:02:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.202\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.202 tagged_above=-999 required=5 tests=[AWL=-0.194,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id AuKECO7ZtDM7 for <notmuch@notmuchmail.org>;\r
+ Mon, 31 Aug 2015 12:02:51 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 3274B6DE00CB\r
+ for <notmuch@notmuchmail.org>; Mon, 31 Aug 2015 12:02:50 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id BA3D510005A;\r
+ Mon, 31 Aug 2015 22:01:22 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: add function to resend message to new\r
+ recipients\r
+In-Reply-To: <87lhcss06e.fsf@maritornes.cs.unb.ca>\r
+References: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>\r
+ <1440619626-18768-2-git-send-email-tomi.ollila@iki.fi>\r
+ <87vbbxrl3g.fsf@maritornes.cs.unb.ca> <m2a8t8257b.fsf@guru.guru-group.fi>\r
+ <87lhcss06e.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 31 Aug 2015 22:01:22 +0300\r
+Message-ID: <m2si6zffjx.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 31 Aug 2015 19:02:53 -0000\r
+\r
+On Mon, Aug 31 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>>\r
+>>   emacs -q -L $PWD/emacs -l emacs/notmuch.el -f notmuch --eval '(progn (setq notmuch-address-command "nottoomuch-addresses.sh") (notmuch-address-message-insinuate))'\r
+>>\r
+\r
+> Ah, I missed notmuch-address-message-insinuate; it does work if I run\r
+> that. I wonder if this can be simplified at all now that\r
+> notmuch-message-mode exists. In general I'm leery of running code when we\r
+> load notmuch*.el, as this has a history of causing problems for people\r
+> using notmuch e.g. as a search tool for gnus.\r
+\r
+Currently as both setting notmuch-address-command and\r
+notmuch-address-message-insinunate us required I would not attempt to do any\r
+"magic" there. Whenever we get built-in address completion (i.e built-in\r
+is used when notmuch-address-command is kept nil we could consider to add\r
+some defcustom which can be used to activate address completion -- but \r
+as there are these *-insinunate -commands in many elisp packages it is\r
+probably best to investigate whether this really can be "automated".\r
+Perhaps some lazy initialization could be in place, then.\r
+\r
+> The completion interface takes a little getting used to, but it's\r
+> definitely usable. And of course much better than what we have now ;).\r
+>\r
+> One thing I noticed which I _think_ is a bug, is that after calling\r
+> notmuch-show-resend-message, notmuch-view-raw-message doesn't work\r
+> anymore, complaining about a read-only buffer.\r
+\r
+That is interesting in a sense that I could not reproduce. I think I know\r
+exactly why this happens: notmuch-view-raw-message creates read-only buffer\r
+which is not removed after message is resent: re-running\r
+notmuch-view-raw-message on same message will `get-buffer-create' with\r
+same name and pick the old read-only buffer; inserting data to that buffer\r
+fails -- just that in my tests (V C-x b RET V) I could not get the same\r
+outcome.\r
+\r
+The simplest change is to change (bury-buffer) with (kill-buffer). The raw\r
+message buffer that was used to send should not be interesting; more\r
+interesting is the current (same) message in notmuch-show buffer -- and 'V'\r
+can be used to re-view the raw message. \r
+What could be added is printing the message id of the message resent to\r
+*Messages* buffer. This way re-sender can verify what was resent if being\r
+unsure. Just that in the case I've used this I have not looked back...\r
+\r
+So, probably I make applicable RFC patch of this feature...\r
+\r
+\r
+>\r
+> d\r
+\r
+Tomi\r