Re: [PATCH] cli/lib: remove support for GMime 2.4

diff --git a/f5/5839de641ab82a2e6251122c13d622a584d9c4 b/f5/5839de641ab82a2e6251122c13d622a584d9c4
new file mode 100644 (file)
index 0000000..2b4adb0
--- /dev/null
+++ b/f5/5839de641ab82a2e6251122c13d622a584d9c4
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id BBD436DE141E\r
+ for <notmuch@notmuchmail.org>; Mon, 17 Aug 2015 02:38:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.236\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.236 tagged_above=-999 required=5 tests=[AWL=-0.160,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 9nv1c-m1xwEF for <notmuch@notmuchmail.org>;\r
+ Mon, 17 Aug 2015 02:38:55 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 770CC6DE0B26\r
+ for <notmuch@notmuchmail.org>; Mon, 17 Aug 2015 02:38:55 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 476D11000CA;\r
+ Mon, 17 Aug 2015 12:37:22 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli/lib: remove support for GMime 2.4\r
+In-Reply-To: <874mjygvyb.fsf@alice.fifthhorseman.net>\r
+References: <1439739201-11068-1-git-send-email-david@tethera.net>\r
+ <m2k2sv2enz.fsf@guru.guru-group.fi> <874mjygvyb.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.20.2+61~g1eba370 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 17 Aug 2015 12:37:22 +0300\r
+Message-ID: <m2k2su6yst.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 17 Aug 2015 09:38:57 -0000\r
+\r
+On Mon, Aug 17 2015, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:\r
+\r
+> On Sun 2015-08-16 21:53:36 +0200, Tomi Ollila wrote:\r
+>> On Sun, Aug 16 2015, David Bremner <david@tethera.net> wrote:\r
+>>\r
+>>> It's becoming a maintenance burden to do anything things with the\r
+>>> crypto glue code twice, once for 2.4 and once for 2.6. I don't have\r
+>>> any 2.4 version available to test on my development machine anymore,\r
+>>> so the 2.4 specific code paths are likely not very well tested.\r
+>>> ---\r
+>>>\r
+>>> I started to rebase the SMIME signature verification patches and got\r
+>>> aggravated at solving the same conflicts twice in every file.\r
+>>>\r
+>>> 2.6.7 is from 2012, so that's a bit newer than some of our\r
+>>> requirements, but I think not so bad. YMMV.\r
+>>\r
+>> Perhaps it is time for me to update to gmime 2.6 in this machine. PITA ;/\r
+>\r
+> Please do, i think gmime 2.4 is really not well-supported upstream any\r
+> more either.\r
+\r
+Hmm, it seems I've been using gmime 2.6(.17 -- now updated to .20) a long\r
+time already -- just that `make distclean` does not see that and I've\r
+been looking that part in my build script...\r
+\r
+Interestingly when David's changes are pushed I have to edit the distclean\r
+part of my build to find new gmime so it can do that (distclean, that is) \r
+successfully ;)\r
+\r
+IMO it is somewhat akward that `make distclean` executes `./configure`\r
+but that is probably something no-one wants to do anything with...\r
+\r
+Tomi\r
+\r
+>\r
+>      --dkg\r