--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id E01DB431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 24 Jun 2012 11:56:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id VSXTpPOBmmAT for <notmuch@notmuchmail.org>;\r
+ Sun, 24 Jun 2012 11:56:22 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 06425431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 24 Jun 2012 11:56:22 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Siryp-0006pQ-EB; Sun, 24 Jun 2012 19:56:17 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Siryp-00045g-5Z; Sun, 24 Jun 2012 19:56:15 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: add function to toggle display of all\r
+ multipart/alternative parts\r
+In-Reply-To: <1340136889-2992-1-git-send-email-jani@nikula.org>\r
+References: <1339775751-18002-1-git-send-email-jani@nikula.org>\r
+ <1340136889-2992-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.13.2+63~g548a9bf (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 24 Jun 2012 19:56:09 +0100\r
+Message-ID: <8762agh73q.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 75a738151befa2cd1cb7a10af76bebc5 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 24 Jun 2012 18:56:23 -0000\r
+\r
+\r
+On Tue, 19 Jun 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> Add function notmuch-show-toggle-multipart-alternative to toggle the\r
+> value of notmuch-show-all-multipart/alternative-parts variable in the\r
+> buffer, and redisplay the thread with either all or preferred\r
+> alternative parts expanded.\r
+>\r
+> A small wrinkle is that in order to make the variable survive\r
+> notmuch-show-refresh-view (which is required for expanding/collapsing\r
+> the parts, but ends up calling kill-all-local-variables through\r
+> notmuch-show-mode) it is necessary to give it the permanent-local\r
+> property.\r
+\r
+Hi \r
+\r
+This patch looks good to me with one small concern: I set the\r
+variable notmuch-show-all-multipart/alternative-parts in my an emacs file\r
+loaded from my .emacs file rather than through customize using \r
+(setq notmuch-show-all-multipart/alternative-parts nil)\r
+\r
+This no longer works because of the buffer local property (ie I see all\r
+parts): I need to use \r
+(setq-default notmuch-show-all-multipart/alternative-parts nil)\r
+\r
+This "change" might be worth flagging up in the news file.\r
+\r
+I do not think the existence of my semi-patch\r
+id:"87pq8vokmp.fsf@qmul.ac.uk" should hold up this patch. My patch is\r
+only a draft and I definitely do not know enough lisp to be able to\r
+write a correct version (with correct quoting of message-ids etc).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+> ---\r
+> emacs/notmuch-show.el | 12 ++++++++++++\r
+> 1 file changed, 12 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 36cad93..4d3f03f 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -98,6 +98,18 @@ any given message."\r
+> "Should all parts of multipart/alternative parts be shown?"\r
+> :type 'boolean\r
+> :group 'notmuch-show)\r
+> +(make-variable-buffer-local 'notmuch-show-all-multipart/alternative-parts)\r
+> +(put 'notmuch-show-all-multipart/alternative-parts 'permanent-local t)\r
+> +\r
+> +(defun notmuch-show-toggle-multipart-alternative ()\r
+> + "Toggle the display of all multipart/alternative parts."\r
+> + (interactive)\r
+> + (setq notmuch-show-all-multipart/alternative-parts\r
+> + (not notmuch-show-all-multipart/alternative-parts))\r
+> + (message (if notmuch-show-all-multipart/alternative-parts\r
+> + "Showing all multipart/alternative parts."\r
+> + "Showing preferred multipart/alternative part."))\r
+> + (notmuch-show-refresh-view))\r
+> \r
+> (defcustom notmuch-show-indent-messages-width 1\r
+> "Width of message indentation in threads.\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff