Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

diff --git a/0a/887c12d0f7b00c96ab8dfa41e7420084e16d51 b/0a/887c12d0f7b00c96ab8dfa41e7420084e16d51
new file mode 100644 (file)
index 0000000..8122e82
--- /dev/null
+++ b/0a/887c12d0f7b00c96ab8dfa41e7420084e16d51
@@ -0,0 +1,97 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 14548431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Aug 2014 16:03:33 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5lcIJk2kWzhW for <notmuch@notmuchmail.org>;\r
+       Sun, 24 Aug 2014 16:03:29 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 37412431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Aug 2014 16:03:29 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XLgoq-0007Al-1X; Sun, 24 Aug 2014 20:03:28 -0300\r
+Received: (nullmailer pid 5134 invoked by uid 1000); Sun, 24 Aug 2014\r
+       23:03:23 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@mit.edu>\r
+Subject: Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained\r
+       "features"\r
+In-Reply-To: <20140824221629.GP3015@mit.edu>\r
+References: <1406859003-11561-1-git-send-email-amdragon@mit.edu>\r
+       <1406859003-11561-5-git-send-email-amdragon@mit.edu>\r
+       <87ppfqsv8s.fsf@maritornes.cs.unb.ca>\r
+       <87fvgmg0tx.fsf@awakening.csail.mit.edu>\r
+       <87zjeu4jyp.fsf@maritornes.cs.unb.ca> <20140824221629.GP3015@mit.edu>\r
+User-Agent: Notmuch/0.18.1+72~g028c560 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 24 Aug 2014 16:03:23 -0700\r
+Message-ID: <871ts5mqx0.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 24 Aug 2014 23:03:33 -0000\r
+\r
+Austin Clements <amdragon@mit.edu> writes:\r
+\r
+> Quoth David Bremner on Aug 23 at  8:58 pm:\r
+>> Austin Clements <amdragon@mit.edu> writes:\r
+>> \r
+>> >>> @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t *notmuch)\r
+>> >>>  notmuch_bool_t\r
+>> >>>  notmuch_database_needs_upgrade (notmuch_database_t *notmuch)\r
+>> >>>  {\r
+>> >>> -    return notmuch->needs_upgrade;\r
+>> >>> +    return notmuch->mode == NOTMUCH_DATABASE_MODE_READ_WRITE &&\r
+>> >>> +       (NOTMUCH_FEATURES_CURRENT & ~notmuch->features);\r
+>> >>>  }\r
+>> >>\r
+>> >> Maybe I'm not thinking hard enough here, but how does this deal with a\r
+>> >> feature that is needed to open a database in read only mode? Maybe it\r
+>> >> needs a comment for people not as clever as Austin ;).\r
+>> >\r
+>> > I'm not quite sure what you mean.  notmuch_database_needs_upgrade\r
+>> > returns false for read-only databases because you can't upgrade a\r
+>> > read-only database.  This was true before this patch, too, though it was\r
+>> > less obvious.  (Maybe that's not what you're asking?)\r
+>> \r
+>> Yes, that's what I was asking. I guess it's orthogonal to your patch\r
+>> series, but the logic of returning FALSE for read only databases is not\r
+>> very intuitive to me (in the sense that "needs upgrade" is not the\r
+>> opposite of "can't be upgraded".  Your new comment later in the series\r
+>> is better, but it would IMHO be even better if you mentioned the read\r
+>> only case.\r
+>\r
+> That's a good point.  Ideally this should be\r
+> "notmuch_database_can_upgrade" or something, which I think would\r
+> capture exactly what it means after this series.  However, I don't\r
+> think it's worth breaking API compatibility given that this is already\r
+> how callers use this function (even though that violates the current\r
+> library spec).\r
+>\r
+> So, how's this for a more updated doc comment on needs_upgrade?\r
+\r
+LGTM\r