--- /dev/null
+Return-Path: <bacuh@riseup.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id AE333431FAF\r
+ for <notmuch@notmuchmail.org>; Fri, 4 Jul 2014 02:25:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.001\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.001 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 8T3r01Yrb0KL for <notmuch@notmuchmail.org>;\r
+ Fri, 4 Jul 2014 02:25:38 -0700 (PDT)\r
+Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id C9DDA431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 4 Jul 2014 02:25:38 -0700 (PDT)\r
+Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (Client CN "*.riseup.net",\r
+ Issuer "Gandi Standard SSL CA" (not verified))\r
+ by mx1.riseup.net (Postfix) with ESMTPS id 5FCBB50E6C;\r
+ Fri, 4 Jul 2014 02:25:37 -0700 (PDT)\r
+Received: from [127.0.0.1] (localhost [127.0.0.1])\r
+ (Authenticated sender: bacuh@fruiteater.riseup.net)\r
+ with ESMTPSA id 2E27E10BF\r
+From: Sebastian Lipp <bacuh@riseup.net>\r
+To: Karl Fogel <kfogel@red-bean.com>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+ notmuch-address.el.\r
+In-Reply-To: <87oax6vt4u.fsf@ktab.red-bean.com>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+ <87mwtah2hd.fsf@zancas.localnet>\r
+ <877gkeau42.fsf@floss.red-bean.com>\r
+ <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+ <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+ <m2hajgxli5.fsf@guru.guru-group.fi>\r
+ <87vc7vgbym.fsf@zancas.localnet>\r
+ <m2ehejykb1.fsf@guru.guru-group.fi>\r
+ <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+ <87oax6vt4u.fsf@ktab.red-bean.com>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+ (i686-pc-linux-gnu)\r
+Date: Fri, 04 Jul 2014 11:25:38 +0200\r
+Message-ID:\r
+ <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Virus-Scanned: clamav-milter 0.98.1 at mx1\r
+X-Virus-Status: Clean\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 Jul 2014 09:25:45 -0000\r
+\r
+Karl Fogel <kfogel@red-bean.com> writes:\r
+> Sebastian Lipp <bacuh@riseup.net> writes:\r
+>>As I'd like to see this in notmuch I made the change. The patch is\r
+>>attached. As it is my first contribution to notmuch at all: Just tell me\r
+>>if I'm supposed to do it in any other way.\r
+>\r
+> I think your patch includes much more than just the above, though.\r
+\r
+True. See below on that.\r
+\r
+>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
+>>index fa65cd5..ee7b169 100644\r
+>>--- a/emacs/notmuch-address.el\r
+>>+++ b/emacs/notmuch-address.el\r
+>>@@ -113,6 +113,59 @@ to know how address selection is made by default."\r
+>> (when (notmuch-address-locate-command notmuch-address-command)\r
+>> (notmuch-address-message-insinuate))\r
+>> \r
+>>+;; functions to add sender / recipients to BBDB\r
+>>+\r
+>>+(defvar bbdb-get-addresses-headers)\r
+>\r
+> I think it's good to include an initial value (even an invalid\r
+> placeholder one, if the real initialization has not happened yet), and a\r
+> doc string. C-h f defvar RET will say more about how to do that.\r
+\r
+I will read into this and get back to it.\r
+\r
+>>+(declare-function notmuch-show-get-header "notmuch-show" (header &optional props))\r
+>>+\r
+>>+(declare-function bbdb-get-addresses "bbdb-com" \r
+>>+ (only-first-address\r
+>>+ uninteresting-senders\r
+>>+ get-header-content-function\r
+>>+ &rest get-header-content-function-args))\r
+>>+\r
+>>+(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))\r
+>\r
+> At this point, your patch has accomplished what Tomi originally\r
+> suggested. But then the patch continues with what looks like\r
+> substantive new code:\r
+>\r
+>>+(defun notmuch-bbdb/snarf-headers (headers)\r
+>>+ ;; Helper function to avoid code duplication in the two below\r
+>>+ ;; headers should have the same format as bbdb-get-addresses-headers\r
+>>+\r
+>>+ ;; bbdb-get-addresses reads these\r
+>>+ ;; Ugh, pass-by-global\r
+>>+ (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content))\r
+>>+ (bbdb-get-addresses-headers headers) ; headers to read\r
+>>+ (bbdb-gag-messages t)) ; suppress m/n processed message)\r
+>>+ (bbdb-update-records addrs t t)))\r
+>>+\r
+>>+(defun notmuch-bbdb/snarf-from ()\r
+>>+ "Import the sender of the current message into BBDB"\r
+>>+ (interactive)\r
+>>+ (notmuch-bbdb/snarf-headers\r
+>>+ (list (assoc 'authors bbdb-get-addresses-headers))))\r
+>>+\r
+>>+(defun notmuch-bbdb/snarf-to ()\r
+>>+ "Import all recipients of the current message into BBDB"\r
+>>+ (interactive)\r
+>>+ (notmuch-bbdb/snarf-headers\r
+>>+ (list (assoc 'recipients bbdb-get-addresses-headers))))\r
+>>+\r
+>>+(defvar notmuch-bbdb/header-by-name\r
+>>+ ;; both are case sensitive\r
+>>+ '( ("From" . :From)\r
+>>+ ("To" . :To)\r
+>>+ ("CC" . :Cc)\r
+>>+ ("BCC" . :Bcc)\r
+>>+ ("Resent-From" . nil)\r
+>>+ ("Reply-To" . nil)\r
+>>+ ("Resent-To" . nil)\r
+>>+ ("Resent-CC" . nil))\r
+>>+ "Alist for dispatching header symbols as used by notmuch-show-get-header\r
+>>+from strings as used by bbdb-get-addresses")\r
+>>+\r
+>>+(defun notmuch-bbdb/get-header-content (name)\r
+>>+ (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name))))\r
+>\r
+> It looks like new code, but I suspect what actually happened is that\r
+> this is just the original code, somehow mis-expressed as "+" lines in\r
+> the patch. Is that what happened?\r
+\r
+No, it happened by intention because what is "original" to you is not\r
+part of my freshly cloned notmuch. So I thought good practise is to\r
+construct *one* patch that brings the already fixed feature to the\r
+notmuch codebase to keep it clean.\r
+\r
+If you like better, my next patch will only base Tomis and your\r
+suggestions on top of the "original" patch.\r
+\r
+basti\r
projects / notmuch-archives.git / commitdiff