[PATCH] emacs: bugfix unquoted symbol
authorMark Walters <markwalters1009@gmail.com>
Sat, 14 Sep 2013 20:17:07 +0000 (21:17 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:57:07 +0000 (09:57 -0800)
7e/15d41d17cb590e10110fc033cde7946c6ef380 [new file with mode: 0644]

diff --git a/7e/15d41d17cb590e10110fc033cde7946c6ef380 b/7e/15d41d17cb590e10110fc033cde7946c6ef380
new file mode 100644 (file)
index 0000000..5afe170
--- /dev/null
@@ -0,0 +1,96 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A820E431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 13:17:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id IEMLXW6eNOpd for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Sep 2013 13:17:14 -0700 (PDT)\r
+Received: from mail-we0-f174.google.com (mail-we0-f174.google.com\r
+       [74.125.82.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E90B3431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 13:17:13 -0700 (PDT)\r
+Received: by mail-we0-f174.google.com with SMTP id q58so2296038wes.5\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 13:17:12 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id;\r
+       bh=87O5cfSjAmGkuu+v5mUIJWMfuQP11ZU8eNlNQAm0/Vs=;\r
+       b=PehO7g5SlWVJ11cr5C6MCo9NrNqKggOxyrSCiweepuAyd4r0GjnuRc68s5wESXE4Xh\r
+       rGXDUwkFIxL9XP/A4ldZBZcRRSiXJB7fHXy4JlQ0wR87EDnFebTXUApRRn2lF+Ijjkac\r
+       utUbexaip9VWuGSS11or/8eNPJcz/7lzKyJO7hdz/wfaYqiPsq4tIY0uJAKUv25h83ws\r
+       cUxMF8NopEu6vUtCj176J1yCXfGxfSBHHKx8Y4bTLv4E614k5TXYvYtzBJdLIE2xzPGz\r
+       bf5lC4g72CdGUK8q0GOiG9jWgqZtgTEyqeJqwrmPUOI8BT1/tnIxRDFQsIoyuva0c6X2\r
+       hTXA==\r
+X-Received: by 10.194.24.168 with SMTP id v8mr16225023wjf.28.1379189832779;\r
+       Sat, 14 Sep 2013 13:17:12 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPSA id i8sm12247180wib.1.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 14 Sep 2013 13:17:12 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: bugfix unquoted symbol\r
+Date: Sat, 14 Sep 2013 21:17:07 +0100\r
+Message-Id: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Sep 2013 20:17:20 -0000\r
+\r
+In the recent changes for search order handling the default-value of\r
+notmuch-search-oldest-first was used. However, default-value needs a\r
+symbol so the symbol-name needs to be quoted.\r
+\r
+This missing quote was causing strange sort-orders in some cases.\r
+---\r
+\r
+I think this is clearly correct (and what was intended) and it seems\r
+to work as expected.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+ emacs/notmuch.el |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 4de6229..0ff248b 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -888,7 +888,7 @@ the configured default sort order."\r
+     nil\r
+     ;; Use the default search order (if we're doing a search from a\r
+     ;; search buffer, ignore any buffer-local overrides)\r
+-    (default-value notmuch-search-oldest-first)))\r
++    (default-value 'notmuch-search-oldest-first)))\r
\r
+   (let* ((query (or query (notmuch-read-query "Notmuch search: ")))\r
+        (buffer (get-buffer-create (notmuch-search-buffer-title query))))\r
+-- \r
+1.7.9.1\r
+\r