Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

diff --git a/fd/63c99f5bc8ee9c9e45d0d55f70f1c749c34de7 b/fd/63c99f5bc8ee9c9e45d0d55f70f1c749c34de7
new file mode 100644 (file)
index 0000000..9930e55
--- /dev/null
+++ b/fd/63c99f5bc8ee9c9e45d0d55f70f1c749c34de7
@@ -0,0 +1,78 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4E76E431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:24:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PMSMuwXFtKRm for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 16:24:00 -0700 (PDT)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id BBAED431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:24:00 -0700 (PDT)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1Xav9k-0000Nh-Bd; Sun, 05 Oct 2014 19:24:00 -0400\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1Xav9k-0004da-3G; Sun, 05 Oct 2014 19:24:00 -0400\r
+Date: Sun, 5 Oct 2014 19:24:00 -0400\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating\r
+       ghost   messages\r
+Message-ID: <20141005232400.GC7970@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-7-git-send-email-aclements@csail.mit.edu>\r
+       <87fvf2q5p5.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87fvf2q5p5.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Oct 2014 23:24:06 -0000\r
+\r
+Quoth David Bremner on Oct 05 at 10:30 am:\r
+> Austin Clements <aclements@csail.mit.edu> writes:\r
+> \r
+> > +      message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST);\r
+> \r
+> What do you think about using bit set / clear / read macros?  I don't\r
+> insist, but I wonder if it would make this part more readable.\r
+\r
+I'm used to reading this stuff, so either way is fine with me.  Do we\r
+have bit set / clear / read macros?\r
+\r
+> > +  else if (*i == "Tghost")\r
+> > +      message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST);\r
+> > +  else\r
+> \r
+> It makes me faintly unhappy to have the prefix hardcoded here.\r
+> Not sure if there is a sensible solution.\r
+\r
+I agree, but I also don't want to construct the test string every time\r
+or deconstruct the term string every time.  I could move the "T"\r
+prefix string to a #define and use that both here and in\r
+BOOLEAN_PREFIX_INTERNAL, but that solution may be worse than the\r
+problem.  What do you think?\r