Re: [PATCH v2] emacs: Improve the cited message included in replies

diff --git a/86/d877b6a3bb61b14e8c3e1b3bd70c565e2c662e b/86/d877b6a3bb61b14e8c3e1b3bd70c565e2c662e
new file mode 100644 (file)
index 0000000..f6642f6
--- /dev/null
+++ b/86/d877b6a3bb61b14e8c3e1b3bd70c565e2c662e
@@ -0,0 +1,149 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4A4C7431FC0\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:11:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 56xUSlTY0z81 for <notmuch@notmuchmail.org>;\r
+       Mon, 12 May 2014 01:11:13 -0700 (PDT)\r
+Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com\r
+       [209.85.212.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5CF54431FBF\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:11:13 -0700 (PDT)\r
+Received: by mail-wi0-f176.google.com with SMTP id n15so4004984wiw.3\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:11:12 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=ycS+rkS1OWHXfrNz2JIn6iFOEOgn6QO7oEE1MIcIcVw=;\r
+       b=EiQidQSqZFSQYQ/DvFaHYF7ZuqIM+7X7ht6yEuoXRdOG9+61PSh/PcrXGCFDJRMUgq\r
+       2JhFjkvynyT8zB8C1J9Evqj05EuQlU9HaA3V+L0OooESobyBf19UrB6wg66REqwQfdIw\r
+       FXt3LCKnqf9YHGXfzF+B8SF5sXDknLaZ7TskbyqxGxGnZCuJJaoQHDVDS8AR0bF9QxuH\r
+       zK5mrdGUYN6tOyCcaMGwVWazcaDtLBE6McIjBGiPDewZ4nuZKwnlfIGRzVeyGbQeRXhS\r
+       lWIQO/2nQjzuDgbDlihnTR9s7c5ioNsknLUasRL+/wY+pcolHFbZ+OmedTHV0rbGVXOu\r
+       dqtw==\r
+X-Received: by 10.194.122.6 with SMTP id lo6mr20077133wjb.38.1399882272255;\r
+       Mon, 12 May 2014 01:11:12 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+       by mx.google.com with ESMTPSA id c7sm16890357wjf.19.2014.05.12.01.11.11\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 12 May 2014 01:11:11 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Improve the cited message included in replies\r
+In-Reply-To: <cunzjinbkfr.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <1399482846-25308-1-git-send-email-dme@dme.org>\r
+       <1399530272-11857-1-git-send-email-dme@dme.org>\r
+       <87ha4y8286.fsf@qmul.ac.uk>\r
+       <cunzjinbkfr.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 May 2014 09:11:10 +0100\r
+Message-ID: <87mwenzaap.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 08:11:19 -0000\r
+\r
+On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> On Sat, May 10 2014, Mark Walters wrote:\r
+>> On Thu, 08 May 2014, David Edmondson <dme@dme.org> wrote:\r
+>>> emacs: Improve the cited message included in replies\r
+>>>\r
+>>> v2:\r
+>>> - Don't run the text/plain hooks when generating the message to quote.\r
+>>>\r
+>>\r
+>> In principle I like this approach: keeping show and reply closely linked\r
+>> seems good.\r
+>>\r
+>> At the moment, as you say, the tests don't all pass. The first reason is\r
+>> that this puts in buttons for the parts. Stopping that happening is not\r
+>> completely trivial as we need to make sure that the instruction gets\r
+>> passed down to sub-parts of multiparts etc. (You could argue that the\r
+>> 'no-button option to notmuch-show-insert-bodypart is buggy as it only\r
+>> stops the top level button for the part)\r
+>\r
+> That seems straightforward. I was sure that there was a variable listing\r
+> part types that didn't require buttons (which could be let-bound), but I\r
+> must have been imagining it.\r
+>\r
+> Inserting the button text for the trivial case (single text/plain part)\r
+> is already special-cased in the show code. In the case where only a\r
+> single part is being shown (e.g. multipart/alternative with text/plain\r
+> and text/html with the text/html hidden) it would make sense _not_ to\r
+> show the button text. For more complex messages (e.g. multipart/mixed\r
+> with text/plain and message/rfc822, where the message/rfc822 contains\r
+> multiple parts), showing the button text seems useful to allow the\r
+> different sub-sections of the reply to be distinguished.\r
+\r
+Yes that is true: I hadn't thought of that.\r
+\r
+> Perhaps there is an approach based on the complexity of the quoted\r
+> message that should determine whether the button text is inserted (which\r
+> might also apply (in modified form?) in normal message display)? Normal\r
+> message display has to allow for some interaction with the parts\r
+> (show/hide, etc.), which doesn't apply to citation.\r
+>\r
+>> Secondly, the existing code only includes text sub-parts of the\r
+>> message. I would think your version might include any sub-parts show is\r
+>> configured to display, including, say images. (However, in my testing\r
+>> images didn't seem to be included: I am not sure why.)\r
+>\r
+> Eek.\r
+\r
+I phrased this badly. I don't want images included: I just couldn't see\r
+why they weren't with your current patch (as they are displayed in show\r
+mode)\r
+\r
+>\r
+> Inserting the images in the reply buffer itself would not be\r
+> difficult. What should happen when the user hits 'send'? We currently\r
+> don't have a composition mode that would allow us to generate useful\r
+> output in that case. Adding one feels like a lot of work. In many cases\r
+> it would be necessary to transform the message into HTML to properly\r
+> represent the content.\r
+>\r
+> MML (the markup used in `message-mode') is really not designed for\r
+> something this complex.\r
+>\r
+>> I can't tell how much work it is to modify show to take account of these\r
+>> things, so am not sure if this is the best approach, or just adding\r
+>> something to deal with rfc822 to our existing reply code is easier.\r
+>\r
+> The approach in this patch mostly involves removing code - adding\r
+> special case code to notmuch-mua.el to support message/rfc822 involves\r
+> _adding_ a bunch more complex code (I tried that first).\r
+\r
+I guess my concern with adding to the show code is that is already more\r
+complicated than I would like (invisibility, hidden parts, lazy parts\r
+etc). But I am very definitely interested in seeing what a more finished\r
+version of your patch would look like.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r