Fixed missing directory error when merging comments onto a bare bug.
authorW. Trevor King <wking@drexel.edu>
Thu, 4 Dec 2008 17:07:49 +0000 (12:07 -0500)
committerW. Trevor King <wking@drexel.edu>
Thu, 4 Dec 2008 17:07:49 +0000 (12:07 -0500)
If bug_A had no comments (and so, no comment directory), changing
comment settings before saving raised missing directory errors.
save_settings had previously assumed the
 .be/bugs/XYZ/comments/
directory existed, which wasn't true for comment-less bugs.  Now it
checks, and creates the directory if necessary.

12 files changed:
.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/body [new file with mode: 0644]
.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/values [new file with mode: 0644]
.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/values
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/body [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/values [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/body [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/values [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/body [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/values [new file with mode: 0644]
.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/values
.be/settings
libbe/comment.py

diff --git a/.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/body b/.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/body
new file mode 100644 (file)
index 0000000..ab2dc28
--- /dev/null
@@ -0,0 +1 @@
+Merged into bug ae998b27-a11b-4243-abf6-11841e5b8242
\ No newline at end of file
diff --git a/.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/values b/.be/bugs/4a4609c8-1882-47de-9d30-fee410b8a802/comments/0ac3c4cb-90e3-4b67-b6cb-1186d5d66240/values
new file mode 100644 (file)
index 0000000..667dc94
--- /dev/null
@@ -0,0 +1,8 @@
+Content-type: text/plain
+
+
+Date: Thu, 04 Dec 2008 17:05:50 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
index 84075292ccdd869fc6d57fcf71743460f6082f1c..37197a777170b04e732935a9ef6a5c90fdf1f372 100644 (file)
@@ -4,7 +4,7 @@ creator: abentley
 severity: minor
 
 
-status: fixed
+status: closed
 
 
 summary: Do we need a severity between serious and minor? EG "Moderate"?
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/body b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/body
new file mode 100644 (file)
index 0000000..6c46db0
--- /dev/null
@@ -0,0 +1 @@
+Merged from bug 4a4609c8-1882-47de-9d30-fee410b8a802
\ No newline at end of file
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/values b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/2628eeca-96c6-4933-8484-d55bb1dbf985/values
new file mode 100644 (file)
index 0000000..afd88e5
--- /dev/null
@@ -0,0 +1,8 @@
+Content-type: text/plain
+
+
+Date: Thu, 04 Dec 2008 17:05:49 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/body b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/body
new file mode 100644 (file)
index 0000000..d0b8404
--- /dev/null
@@ -0,0 +1 @@
+Implemented.
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/values b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/942cd941-583d-4020-99e4-80de7e836129/values
new file mode 100644 (file)
index 0000000..366395d
--- /dev/null
@@ -0,0 +1,11 @@
+Content-type: text/plain
+
+
+Date: Thu, 04 Dec 2008 15:42:07 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
+
+In-reply-to: 2628eeca-96c6-4933-8484-d55bb1dbf985
+
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/body b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/body
new file mode 100644 (file)
index 0000000..f7659c3
--- /dev/null
@@ -0,0 +1 @@
+Per-tree severity and status levels are now supported.
diff --git a/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/values b/.be/bugs/ae998b27-a11b-4243-abf6-11841e5b8242/comments/ae0f9aea-960c-42b4-82df-943bbbe17d58/values
new file mode 100644 (file)
index 0000000..80e328b
--- /dev/null
@@ -0,0 +1,8 @@
+Content-type: text/plain
+
+
+Date: Thu, 04 Dec 2008 17:07:25 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
index 8a5d9e2ea7b1f63f504d7dbe306d4406489bf417..2f65fbcf448354649ecdb99407ba71ca3a286d11 100644 (file)
@@ -1,28 +1,11 @@
+creator: abentley
 
 
+severity: minor
 
-creator=abentley
 
+status: fixed
 
 
-
-
-
-severity=minor
-
-
-
-
-
-
-status=open
-
-
-
-
-
-
-summary=Customizable severity levels?
-
-
+summary: Customizable severity levels?
 
index 44c2cd5c5f30138545e54852b45a7dd919dc4cfd..a9bd6dd6de2a175ed832fa0305c5867eb1f855ce 100644 (file)
@@ -1,6 +1,3 @@
-rcs_name: bzr
-
-
 inactive_status:
 - - closed
   - The bug is no longer relevant.
@@ -10,3 +7,7 @@ inactive_status:
   - It's not a bug, it's a feature.
 - - disabled
   - Unknown meaning.  For backwards compatibility with old BE bugs.
+
+
+rcs_name: bzr
+
index 6c0e5c099f925e39a1766efca12c405e3c874f85..cb5ea59f7243e8fa217b56a1f815dd17f010537c 100644 (file)
@@ -275,6 +275,8 @@ class Comment(Tree, settings_object.SavedSettingsObject):
         self._setup_saved_settings()
 
     def save_settings(self):
+        parent_dir = os.path.dirname(self.get_path())
+        self.rcs.mkdir(parent_dir)
         self.rcs.mkdir(self.get_path())
         path = self.get_path("values")
         mapfile.map_save(self.rcs, path, self._get_saved_settings())