Re: [PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

diff --git a/34/9b50cbc54c9e4131ea90d1c23235b34fb9ac0c b/34/9b50cbc54c9e4131ea90d1c23235b34fb9ac0c
new file mode 100644 (file)
index 0000000..8785dae
--- /dev/null
+++ b/34/9b50cbc54c9e4131ea90d1c23235b34fb9ac0c
@@ -0,0 +1,87 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 090F7431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:59:33 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OlGUaz7N8gRP for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Oct 2012 19:59:31 -0700 (PDT)\r
+Received: from mail-qa0-f53.google.com (mail-qa0-f53.google.com\r
+       [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1BE3C431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:59:30 -0700 (PDT)\r
+Received: by mail-qa0-f53.google.com with SMTP id s11so2262510qaa.5\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:59:30 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=oPEb/8JMIqa3O8onKXfxJmplVhTbnTez/SM91WVbxUo=;\r
+       b=NTxkFMyLLoF6Vi1l7R4LQ5d1QL2Qc6rz3zBkbq6mXJONgZ8IjWvD0qCaha2P2g4I5d\r
+       xs0i47Zmum/vSuz29DC6bCG8xqpVjcz64pc3qbjKzhgo1iK1LNp850H53jLwCGAEQDLw\r
+       gzTK2N/Hswjyz21LufhGzkMME63wcQ8TGk70deAV2fIyQuhyGselgMF0I1lylU/LPhpC\r
+       fhdPH5Wt+aA7TGjS3GbcZ4dDmWPVsB7XY6CTM3WXYXX2tz11djTuCMjByzgLXY1M3swF\r
+       II+1ZtMEgmfIZtqJoSqlpU7CuvYOi4azayYzSM2CXGykMsJON5flO2qICL1KjQ3KCt3P\r
+       uquA==\r
+Received: by 10.229.106.14 with SMTP id v14mr1670541qco.85.1350356370499;\r
+       Mon, 15 Oct 2012 19:59:30 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id cz8sm11525132qab.21.2012.10.15.19.59.28\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 15 Oct 2012 19:59:29 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>, Pieter Praet <pieter@praet.org>,\r
+       David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 4/6] emacs: add optional predicate arg to\r
+       `notmuch-show-mapc'\r
+In-Reply-To: <87vclywxek.fsf@qmul.ac.uk>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+       <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+       <1330122640-18895-5-git-send-email-pieter@praet.org>\r
+       <87vclywxek.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 15 Oct 2012 22:59:27 -0400\r
+Message-ID: <87obk386ls.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Oct 2012 02:59:33 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> The original function feels a little fragile to me as to what happens if\r
+> predicate or function move point. Eg what happens if function collapses\r
+> the message: where does point go, and so where does\r
+> notmuch-show-goto-message-next go. Is this just my naivete as a lisp\r
+> beginner? Is there someway of writing it so the user doesn't need to\r
+> worry about such things?\r
+\r
+Although collapsing the message doesn't seem to move point, it would\r
+probably be a good idea to wrap the calls to predicate and function in\r
+save-excursion, as a guard against subtle and hard-to-spot bugs with\r
+operations not being applied to all the right messages..\r
+\r
+Ethan\r