Re: [PATCH] configure: only install bash completion if supported

diff --git a/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e b/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e
new file mode 100644 (file)
index 0000000..963a06b
--- /dev/null
+++ b/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e
@@ -0,0 +1,116 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2080D431FBD\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 09:43:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jWQIeXdHS31S for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Feb 2014 09:43:08 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D846B431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 09:43:07 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WA14O-0001NQ-CG; Sun, 02 Feb 2014 17:43:02 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WA13U-0007dP-Vh; Sun, 02 Feb 2014 17:42:05 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] configure: only install bash completion if supported\r
+In-Reply-To: <1391359677-12497-1-git-send-email-jani@nikula.org>\r
+References: <1391359677-12497-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 02 Feb 2014 17:40:38 +0000\r
+Message-ID: <877g9dqup5.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: bc4a3a4d2c7913277a1edf16efa1e1a5 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Feb 2014 17:43:16 -0000\r
+\r
+\r
+This LGTM (untested)\r
+\r
+I think this is the right way to do this: I don't think we should\r
+spam a user with error messages for attempting tab completion with\r
+an older version of bash-completion (which I think you said was the case\r
+with the other version)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Sun, 02 Feb 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> Our bash completion depends on bash-completion 1.90 or later. Only\r
+> install where available.\r
+> ---\r
+>  configure | 8 ++++++++\r
+>  1 file changed, 8 insertions(+)\r
+>\r
+> diff --git a/configure b/configure\r
+> index 13b6062..66aaedb 100755\r
+> --- a/configure\r
+> +++ b/configure\r
+> @@ -360,6 +360,14 @@ else\r
+>      have_valgrind=0\r
+>  fi\r
+>  \r
+> +printf "Checking for bash-completion (>= 1.90)... "\r
+> +if pkg-config --atleast-version=1.90 bash-completion; then\r
+> +    printf "Yes.\n"\r
+> +else\r
+> +    printf "No (will not install bash completion).\n"\r
+> +    WITH_BASH=0\r
+> +fi\r
+> +\r
+>  if [ -z "${EMACSLISPDIR}" ]; then\r
+>      if pkg-config --exists emacs; then\r
+>      EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir)\r
+> -- \r
+> 1.8.5.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r