Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return status codes

diff --git a/0f/17369dc96c504f7f7904d1baea683b9ab2b1d8 b/0f/17369dc96c504f7f7904d1baea683b9ab2b1d8
new file mode 100644 (file)
index 0000000..3b51e22
--- /dev/null
+++ b/0f/17369dc96c504f7f7904d1baea683b9ab2b1d8
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9081C431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  2 May 2012 12:09:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4Dt8bDhfM6Iq for <notmuch@notmuchmail.org>;\r
+       Wed,  2 May 2012 12:09:04 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F204431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  2 May 2012 12:09:04 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 61BE068057; Wed,  2 May 2012 22:08:54 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/6] Make notmuch_database_{open,\r
+       create} return status codes\r
+In-Reply-To: <1335803138-24024-1-git-send-email-amdragon@mit.edu>\r
+References: <1335651473-19652-1-git-send-email-amdragon@mit.edu>\r
+       <1335803138-24024-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.12+160~g9c17781 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 02 May 2012 22:08:54 +0300\r
+Message-ID: <m2ipge9z95.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 02 May 2012 19:09:05 -0000\r
+\r
+On Mon, Apr 30 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Relative to v1, this makes notmuch_database_open and\r
+> notmuch_database_create gracefully handle a NULL out-argument and adds\r
+> documentation of the possible error return values from these two\r
+> functions.  Patches 3 and on have not changed.\r
+\r
+LGTM. \r
+\r
+One question though:\r
+\r
+In bindings/python/notmuch/database.py class Database functions\r
+create() and open() have the following last lines:\r
+\r
++        if status != STATUS.SUCCESS:\r
++            raise NotmuchError(status)\r
++        self._db = db\r
++        return status\r
+\r
+What is the point returning 'status' in the only case the\r
+value is STATUS.SUCCESS -- is some caller interested on this ?\r
+\r
+Tomi\r