Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when...

diff --git a/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f b/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f
new file mode 100644 (file)
index 0000000..e538c4a
--- /dev/null
+++ b/e7/92be12410bf27b3cd9cf7fdb5176e64ddb8f5f
@@ -0,0 +1,102 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D9DCE429E5B\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 05:48:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id uov+nht-Kroi for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 05:48:22 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 2A8AB431FAF   for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 05:48:22 -0800\r
+ (PST)\r
+Received: by wgbdt12 with SMTP id dt12so1141819wgb.2\r
+       for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 05:48:21 -0800 (PST)\r
+Received: by 10.180.93.132 with SMTP id cu4mr11097687wib.9.1328104100875;\r
+       Wed, 01 Feb 2012 05:48:20 -0800 (PST)\r
+Received: from localhost ([109.131.39.11])\r
+       by mx.google.com with ESMTPS id t6sm44901431wid.1.2012.02.01.05.48.19\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 01 Feb 2012 05:48:20 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: David Edmondson <dme@dme.org>, David Bremner <david@tethera.net>,\r
+       Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn\r
+       ..." with "(when ..."\r
+In-Reply-To: <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <87k44uprvy.fsf@praet.org>\r
+       <1326532638-22068-1-git-send-email-pieter@praet.org>\r
+       <87y5ssxam7.fsf@zancas.localnet>\r
+       <CAB+hUn-GmONr24nfxBkt59TzHHyZiD1wioYXoPh9wy-rZR-m2g@mail.gmail.com>\r
+       <87ty3fycje.fsf@zancas.localnet>\r
+       <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Wed, 01 Feb 2012 14:46:19 +0100\r
+Message-ID: <874nva7jkk.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 13:48:25 -0000\r
+\r
+On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:\r
+> > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:\r
+> > > \r
+> > > Sometimes someone (Dmitry?) sent patches that separated a small functional\r
+> > > change, and the big non-functional indentation change it caused,\r
+> > > separately. Would you prefer (or tolerate ;) that style?\r
+> > \r
+> > Hmm, that might be nicer, I'm not 100% sure.\r
+> > \r
+> > I wouldn't say it's mandatory for a patch like this (and I'd say other\r
+> > peoples views on what's easy to review are at least as important as mine\r
+> > here).\r
+> \r
+> Each patch should be valid in the repository without any following\r
+> patches (preceding are obviously okay). Incorrect indentation would\r
+> disqualify a patch from being 'valid', so it shouldn't be accepted.\r
+\r
++1.\r
+\r
+Indentation corrections should always be part of the same patch as\r
+the change(s) that invalidated the indentation in the first place.\r
+\r
+Spotting the *actual* (non-indentation) changes is a non-issue\r
+when using `diff-refine-hunk' (or a wrapper thereof [1]).\r
+\r
+\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r
+\r
+[1] id:"8739ax7jts.fsf@praet.org"\r