Re: [PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

diff --git a/3f/d8db97eb5a4d3e87f3d9970316025818c91105 b/3f/d8db97eb5a4d3e87f3d9970316025818c91105
new file mode 100644 (file)
index 0000000..9633fd2
--- /dev/null
+++ b/3f/d8db97eb5a4d3e87f3d9970316025818c91105
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 71591431FBC\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Jan 2015 05:50:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 72ymR+f5hKIF for <notmuch@notmuchmail.org>;\r
+       Sat,  3 Jan 2015 05:50:09 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 24C7A431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Jan 2015 05:50:09 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 591D5100051;\r
+       Sat,  3 Jan 2015 15:49:37 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] completion: generate notmuch-completion.zsh\r
+       using   doc/conf.py\r
+In-Reply-To: <87387sxaa7.fsf@maritornes.cs.unb.ca>\r
+References: <1420289900-29717-1-git-send-email-david@tethera.net>\r
+       <1420289900-29717-2-git-send-email-david@tethera.net>\r
+       <87387sxaa7.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.19+14~ge04617b (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 03 Jan 2015 15:49:36 +0200\r
+Message-ID: <m2tx08as9b.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 03 Jan 2015 13:50:12 -0000\r
+\r
+On Sat, Jan 03 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> I noticed that the (out of date) list of subcommands was simply\r
+>> repeating the summary lines from the manpage. Since those summary\r
+>> lines are already kept in machine readable form in doc/conf.py,\r
+>> it's easy to compute that part of the completion file.\r
+>\r
+> I meant to annotate this, but lost a fight with git-send-email.  I'm not\r
+> sure if the change to notmuch-completions.zsh is worth the trouble (how\r
+> often will we add subcommands?), but the configuration change should\r
+> probably go in anyway, at least one person already mentioned this in a\r
+> bug report.\r
+\r
+I agree that 2/2 may be left out (I rather skip checking it for now ;)\r
+\r
+The changes in 1/2 looks good, but you could have included the new python\r
+definition in line ~454 in (new) configure, which originally is:\r
+\r
+    if hash sphinx-build > /dev/null 2>&1 && python -m sphinx.writers.manpage >/dev/null 2>&1 ; then\r
+\r
+(actually, this could be like:\r
+\r
+    if command -v sphinx-build >/dev/null && "$python" -m sphinx.writers.manpage >/dev/null 2>&1 ; then\r
+\r
+    (add that 2>&1 to be consistent with other code, I did not include it\r
+    as I think it is wrong to do so ;))\r
+\r
+\r
+Tomi\r