fix uninitialized value problem

This occurred when a plugin, loaded earlier, filled out a template in its
checkconfig, before recentchanges's checkconfig had run. Since such a
template won't be a recentchanges template, just test for the value being
uninitialized and skip processing.

diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm
index 3020b6a6a3d1ecd59a12fe3e89cdcc620d5456bc..f4f9ca348d84a569e866a3cfd33837a24d664a0c 100644 (file)
--- a/IkiWiki/Plugin/recentchanges.pm
+++ b/IkiWiki/Plugin/recentchanges.pm
@@ -40,14 +40,8 @@ sub pagetemplate (@) { #{{{
        my $template=$params{template};
        my $page=$params{page};
 
-       # XXX this is here because I've been seeing a strange uninitialized
-       # value in this sub.
-       if (! defined $config{recentchangespage}) {
-               eval q{use Carp};
-               Carp::cluck("undefined recentchangespage; please report this to Joey");
-       }
-
-       if ($config{rcs} && $page ne $config{recentchangespage} &&
+       if (defined $config{recentchangespage} && $config{rcs} &&
+           $page ne $config{recentchangespage} &&
            $template->query(name => "recentchangesurl")) {
                $template->param(recentchangesurl => urlto($config{recentchangespage}, $page));
                $template->param(have_actions => 1);