projects
/
git.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9c6bebd
)
unpack_object_header_buffer(): clear the size field upon error
author
Junio C Hamano
<gitster@pobox.com>
Thu, 27 Oct 2011 18:42:57 +0000
(11:42 -0700)
committer
Junio C Hamano
<gitster@pobox.com>
Thu, 27 Oct 2011 18:42:57 +0000
(11:42 -0700)
The callers do not use the returned size when the function says
it did not use any bytes and sets the type to OBJ_BAD, so this
should not matter in practice, but it is a good code hygiene
anyway.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sha1_file.c
patch
|
blob
|
history
diff --git
a/sha1_file.c
b/sha1_file.c
index 27f3b9b278a97f66f92ca61a2bc39e30f0a70317..833f5b9b5820ce60f9fb99f6c9bcdb313ae8fca9 100644
(file)
--- a/
sha1_file.c
+++ b/
sha1_file.c
@@
-1267,7
+1267,8
@@
unsigned long unpack_object_header_buffer(const unsigned char *buf,
while (c & 0x80) {
if (len <= used || bitsizeof(long) <= shift) {
error("bad object header");
- return 0;
+ size = used = 0;
+ break;
}
c = buf[used++];
size += (c & 0x7f) << shift;