Re: Bug: notmuch new chokes on dangling symlinks and quits

diff --git a/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 b/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6
new file mode 100644 (file)
index 0000000..74276dc
--- /dev/null
+++ b/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6
@@ -0,0 +1,104 @@
+Return-Path: <eric@deptj.eu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B36C431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 09:07:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GdsGa-AaDo84 for <notmuch@notmuchmail.org>;\r
+       Mon, 27 Jan 2014 09:07:20 -0800 (PST)\r
+X-Greylist: delayed 4288 seconds by postgrey-1.32 at olra;\r
+       Mon, 27 Jan 2014 09:07:20 PST\r
+Received: from earth.solardns.com (earth.solardns.com [94.76.229.85])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6A1A4431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 09:07:20 -0800 (PST)\r
+Received: from cpc1-finc12-2-0-cust846.4-2.cable.virginm.net\r
+       ([82.18.251.79]:56145 helo=teckel.deptj.eu)\r
+       by earth.solardns.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)\r
+       (Exim 4.82) (envelope-from <eric@deptj.eu>) id 1W7oXN-0002vd-OH\r
+       for notmuch@notmuchmail.org; Mon, 27 Jan 2014 15:55:49 +0000\r
+Received: from eric by teckel.deptj.eu with local (Exim 4.71)\r
+       (envelope-from <eric@deptj.eu>) id 1W7oXN-000601-18\r
+       for notmuch@notmuchmail.org; Mon, 27 Jan 2014 15:55:49 +0000\r
+Date: Mon, 27 Jan 2014 15:55:49 +0000\r
+Message-Id: <E1W7oXN-000601-18@teckel.deptj.eu>\r
+From: Eric <eric@deptj.eu>\r
+Subject: Re: Bug: notmuch new chokes on dangling symlinks and quits\r
+To: notmuch <notmuch@notmuchmail.org>\r
+In-Reply-To: <20140127011427.GD10844@boo.workgroup>\r
+References: <20140126131846.GA10844@boo.workgroup>\r
+       <878uu2n17j.fsf@zancas.localnet>\r
+       <20140127011427.GD10844@boo.workgroup>\r
+X--MailScanner-Information: Please contact the ISP for more information\r
+X--MailScanner-ID: 1W7oXN-0002vd-OH\r
+X--MailScanner: Not scanned: please contact your Internet E-Mail Service\r
+       Provider for details\r
+X--MailScanner-SpamCheck: \r
+X--MailScanner-From: eric@deptj.eu\r
+X-AntiAbuse: This header was added to track abuse,\r
+       please include it with any abuse report\r
+X-AntiAbuse: Primary Hostname - earth.solardns.com\r
+X-AntiAbuse: Original Domain - notmuchmail.org\r
+X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]\r
+X-AntiAbuse: Sender Address Domain - deptj.eu\r
+X-Get-Message-Sender-Via: earth.solardns.com: authenticated_id: deptjeu/from_h\r
+X-Source: \r
+X-Source-Args: \r
+X-Source-Dir: \r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jan 2014 17:07:27 -0000\r
+\r
+On Mon, 27 Jan 2014 02:14:27 +0100, Gregor Zattler <telegraph@gmx.net> wrote:\r
+> Hi David,\r
+> * David Bremner <david@tethera.net> [26. Jan. 2014]:\r
+> > Gregor Zattler <telegraph@gmx.net> writes:\r
+> >> I consider this to be a bug.  Instead notmuch should simply\r
+> >> ignore the symlink.\r
+> >>\r
+> > \r
+> > Since there is a test for specifically this behaviour, I'd have to say\r
+> > it's a design decision you don't agree with, not a bug ;).\r
+> \r
+> May I ask why this is so?\r
+\r
+I have no idea what went on with such a decision, but, from the outside:\r
+\r
+1) A dangling symlink should probably be handled in the same way as\r
+   an unreadable file, but would need a separate test because it is\r
+   a separate condition.\r
+\r
+2) A dangling symlink should not be a normal condition anywhere, why do\r
+   you have them?\r
+\r
+3) I am even more amazed that there should be a dangling symlink in a\r
+   Maildir tree.\r
+> \r
+> > In any case, if there is just a few broken symlinks, and you want to\r
+> > ignore them, you can add them the ignore= line in .notmuch-config\r
+> \r
+> Thanks, I deleted some, and ignored others.  Insofar my problem is\r
+> solved. \r
+\r
+Eric\r
+-- \r
+ms fnd in a lbry\r