Re: [PATCH v4 12/16] add --try-decrypt to notmuch new

diff --git a/09/3c9376a873c35b35cf28093a39b03dd2a3438b b/09/3c9376a873c35b35cf28093a39b03dd2a3438b
new file mode 100644 (file)
index 0000000..38d7979
--- /dev/null
+++ b/09/3c9376a873c35b35cf28093a39b03dd2a3438b
@@ -0,0 +1,81 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E887B6DE4F43\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 17:43:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.007\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id D3ADGX0Zk4fU for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Aug 2016 17:42:54 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 333846DE4F51\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 17:22:13 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bYjC5-00053C-AC; Sat, 13 Aug 2016 20:22:25 -0400\r
+Received: (nullmailer pid 31070 invoked by uid 1000);\r
+ Sun, 14 Aug 2016 00:22:09 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 12/16] add --try-decrypt to notmuch new\r
+In-Reply-To: <1467970047-8013-13-git-send-email-dkg@fifthhorseman.net>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-13-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 14 Aug 2016 09:22:09 +0900\r
+Message-ID: <87y44042tq.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Aug 2016 00:43:02 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> Try to decrypt any encrypted parts of newly-discovered messages while\r
+> indexing them.  The cleartext of any successfully-decrypted messages\r
+> will be indexed, with tags applied in the same form as from notmuch\r
+> insert --try-decrypt.\r
+\r
+s/tags/properties/?  At this point I'm a bit lost, and not sure where\r
+those properties are documented, but this commit message is a bit\r
+strange since it kindof implies the reader is likely to know what those\r
+are.\r
+\r
+> diff --git a/notmuch-new.c b/notmuch-new.c\r
+> index c55dea7..e495557 100644\r
+> --- a/notmuch-new.c\r
+> +++ b/notmuch-new.c\r
+> @@ -49,6 +49,7 @@ typedef struct {\r
+>      size_t new_tags_length;\r
+>      const char **new_ignore;\r
+>      size_t new_ignore_length;\r
+> +    notmuch_indexopts_t *indexopts;\r
+\r
+I'm only reading the patch here, but is this variable actually used?\r
+\r
+>      int total_files;\r
+>      int processed_files;\r
+> @@ -260,7 +261,8 @@ add_file (notmuch_database_t *notmuch, const char *filename,\r
+>      if (status)\r
+>      goto DONE;\r
+\r